Problem with vim-daily builds: test63 FAILED (on Launchpad's build system)

[Daniel Hahler]

Hi,

I have setup a vim-daily PPA for nighly builds of Vim, but it fails to
build because of test63.

The complete build log can be seen at:

https://launchpadlibrarian.net/190297666/buildlog_ubuntu-utopic-i386.vim_2%3A7.4.471-1%2Bdaily1%7E6349%7E1%7Ee4878c5%7Eubuntu14.10.1_FAILEDTOBUILD.txt.gz


This appears to be related to Canonical's / Ubuntu's build systems.

I've found the following diff between Debian's and Ubuntu's debian/rules file,
which is used for building the package, where failures of another test (test86) are ignored in Ubuntu:

--- d/vim-7.4.488/debian/rules 2014-10-23 03:01:13.000000000 +0200
+++ u/vim-7.4.273/debian/rules 2014-05-02 05:39:48.000000000 +0200
@@ -3,7 +3,7 @@
export DH_OPTIONS

# Upstream handles the _FORTIFY_SOURCE flag on their own
-DEB_BUILD_MAINT_OPTIONS=hardening=+all,-fortify
+DEB_BUILD_MAINT_OPTIONS=hardening=-fortify

ifneq (,$(wildcard /usr/share/dpkg/default.mk))
include /usr/share/dpkg/default.mk
@@ -323,10 +323,11 @@
# language interfaces.
if [ $(MAKETEST) = "yes" ]; then \
if [ -e src/vim-nox/vim ]; then \
- $(MAKE) -j1 -C src/vim-nox test; \
+ $(MAKE) -j1 -C src/vim-nox test || true; \
else \
- $(MAKE) -j1 -C src/vim-basic test; \
+ $(MAKE) -j1 -C src/vim-basic test || true; \
fi; \
+ [ $$(find src -type f -name '*.failed' \! -name 'test86.failed' | wc -l) -eq 0 ]; \
fi
# installvimbin installs the vim binary under debian/tmp but we install
# it into the vim package from src/. Need to rm it from debian/tmp so

The changelog entry for this is:

vim (2:7.4.000-1ubuntu2) saucy; urgency=low

…
* Ignore test86 for now, as it seems to do goofy things on powerpc.

-- Adam Conrad <adco...@ubuntu.com> Sun, 11 Aug 2013 13:11:28 -0600


It would be nice to have test63 fixed, instead of adding a workaround of not
running the tests, or ignoring test63 failures.

Because I am using Debian's packaging branch, no failing tests are currently being ignored.


Some references about the daily build setup:

- The vim-daily build recipe: https://code.launchpad.net/~pkg-vim/+recipe/vim-daily (just setup again, after moving the packaging branch)

- The build uses Vim's code imported via the vim-jp Git mirror (https://code.launchpad.net/~vcs-imports/vim/master), and the mirror of Debian's pkg-vim packaging branch (https://code.launchpad.net/~pkg-vim/vim/pkg-vim-mirror).

[Christian Brabandt]

Hi Daniel!

On Fr, 14 Nov 2014, Daniel Hahler wrote:

> Hi,
>
> I have setup a vim-daily PPA for nighly builds of Vim, but it fails to
> build because of test63.
>
> The complete build log can be seen at:
>
> https://launchpadlibrarian.net/190297666/buildlog_ubuntu-utopic-i386.vim_2%3A7.4.471-1%2Bdaily1%7E6349%7E1%7Ee4878c5%7Eubuntu14.10.1_FAILEDTOBUILD.txt.gz

Under what terminal are those tests running? Somehow, Vim doesn't pick
up the correct terminal or it is a simple dumb terminal which does not
support coloring which causes the failure of test63

Here is a patch to fix this:

diff --git a/src/testdir/test63.in b/src/testdir/test63.in
--- a/src/testdir/test63.in
+++ b/src/testdir/test63.in
@@ -4,6 +4,7 @@ Test for ":match", ":2match", ":3match",
STARTTEST
:so small.vim
:set encoding=utf8
+:if empty(&t_Co) | e! test.ok | w! test.out | qa! | endif
:" --- Check that "matcharg()" returns the correct group and pattern if a match
:" --- is defined.
:let @r = "*** Test 1: "


Best,
Christian
--
Das ganze Leben besteht aus
Wollen und Nichtvollbringen,
Vollbringen und Nichtwollen.
-- Goethe, Maximen und Reflektionen, Nr. 694

[Bram Moolenaar]

Christian wrote:

> On Fr, 14 Nov 2014, Daniel Hahler wrote:
>
> > Hi,
> >
> > I have setup a vim-daily PPA for nighly builds of Vim, but it fails to
> > build because of test63.
> >
> > The complete build log can be seen at:
> >
> > https://launchpadlibrarian.net/190297666/buildlog_ubuntu-utopic-i386.vim_2%3A7.4.471-1%2Bdaily1%7E6349%7E1%7Ee4878c5%7Eubuntu14.10.1_FAILEDTOBUILD.txt.gz
>
> Under what terminal are those tests running? Somehow, Vim doesn't pick
> up the correct terminal or it is a simple dumb terminal which does not
> support coloring which causes the failure of test63
>
> Here is a patch to fix this:

Thanks!

--
I wonder, do vegetarians eat fruit bats?

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Daniel Hahler]

Am Samstag, 15. November 2014 13:57:20 UTC+1 schrieb Christian Brabandt:

> > I have setup a vim-daily PPA for nighly builds of Vim, but it fails to
> > build because of test63.
> >
> > The complete build log can be seen at:
> >
> > https://launchpadlibrarian.net/190297666/buildlog_ubuntu-utopic-i386.vim_2%3A7.4.471-1%2Bdaily1%7E6349%7E1%7Ee4878c5%7Eubuntu14.10.1_FAILEDTOBUILD.txt.gz
>
> Under what terminal are those tests running?

I don't know unfortunately, but have asked on the #launchpad IRC channel. Hopefully somebody will respond.

> Somehow, Vim doesn't pick up the correct terminal or it is a simple dumb
> terminal which does not support coloring which causes the failure of test63

I could imagine that it is a very minimal environment.

> Here is a patch to fix this:

Thank you!
Would be great if that fixed the issue - I am now waiting for it to land in Vim's source tree.

Cheers,
Daniel.

[Christian Brabandt]

Hi Daniel!

On Sa, 15 Nov 2014, Daniel Hahler wrote:

> Thank you! Would be great if that fixed the issue - I am now waiting
> for it to land in Vim's source tree.

Would be good, if you could verify, that this patch fixes the issue.

Best,
Christian
--
Sind die Fischstäbchen für das Mittagessen zu hart geraten? Einfach
auftauen, und schon sind sie weich!

[Daniel Hahler]

Am Samstag, 15. November 2014 21:59:14 UTC+1 schrieb Christian Brabandt:
> Hi Daniel!
>
> On Sa, 15 Nov 2014, Daniel Hahler wrote:
>
> > Thank you! Would be great if that fixed the issue - I am now waiting
> > for it to land in Vim's source tree.
>
> Would be good, if you could verify, that this patch fixes the issue.

It would be a bit cumbersome - having to setup a new packaging branch (via Bzr) etc. But when it trickles in through Vim's source, I will report back.

I've learnt now that $TERM is unset during the builds, and "if you have special requirements, you need to handle them in the build yourself".

I am now wondering why the Ubuntu builds do not fail, but then they are at 2:7.4.273-2ubuntu4 and there have been 3 patches to the test since then.

Cheers,
Daniel.

[Christian Brabandt]

Hi Daniel!

On Sa, 15 Nov 2014, Daniel Hahler wrote:

> Am Samstag, 15. November 2014 21:59:14 UTC+1 schrieb Christian Brabandt:
> > Hi Daniel!
> >
> > On Sa, 15 Nov 2014, Daniel Hahler wrote:
> >
> > > Thank you! Would be great if that fixed the issue - I am now waiting
> > > for it to land in Vim's source tree.
> >
> > Would be good, if you could verify, that this patch fixes the issue.
>
> It would be a bit cumbersome - having to setup a new packaging branch (via Bzr) etc. But when it trickles in through Vim's source, I will report back.
>
> I've learnt now that $TERM is unset during the builds, and "if you have special requirements, you need to handle them in the build yourself".

Well, that explains at least those error messages about term being set
correctly (E355) and then defaulting to ansi.

> I am now wondering why the Ubuntu builds do not fail, but then they are at 2:7.4.273-2ubuntu4 and there have been 3 patches to the test since then.

If I see this correctly, the failing part of test63 has been added with
patch 7.4.330. I am pretty sure it fails, because vim thinks the
terminal can't handle colors and therefore the screenattr() function
returns 0. Alternatively one could set the MyGroup highlighting to
include some kind of term=bold (or similar, it is only necessary to be
different from the normal highlighting).

Best,
Christian
--
Ich wage mal eine Prognose: Es könnte so oder so ausgehen.
-- Ron Atkinson

[Christian Brabandt]

On Sa, 15 Nov 2014, Christian Brabandt wrote:

> If I see this correctly, the failing part of test63 has been added with
> patch 7.4.330. I am pretty sure it fails, because vim thinks the
> terminal can't handle colors and therefore the screenattr() function
> returns 0. Alternatively one could set the MyGroup highlighting to
> include some kind of term=bold (or similar, it is only necessary to be
> different from the normal highlighting).

For completeness, that would be that patch:

diff --git a/src/testdir/test63.in b/src/testdir/test63.in
--- a/src/testdir/test63.in
+++ b/src/testdir/test63.in

@@ -7,7 +7,7 @@ STARTTEST

:" --- Check that "matcharg()" returns the correct group and pattern if a match
:" --- is defined.
:let @r = "*** Test 1: "

-:highlight MyGroup1 ctermbg=red guibg=red
+:highlight MyGroup1 term=bold ctermbg=red guibg=red
:highlight MyGroup2 ctermbg=green guibg=green
:highlight MyGroup3 ctermbg=blue guibg=blue
:match MyGroup1 /TODO/


Mit freundlichen Grüßen
Christian
--
Oft sind am besten Menschen dessen größte Tugenden und größte Flecken
unbekannt.
-- Jean Paul

[Bram Moolenaar]

Christian wrote:

> On Sa, 15 Nov 2014, Christian Brabandt wrote:
>
> > If I see this correctly, the failing part of test63 has been added with
> > patch 7.4.330. I am pretty sure it fails, because vim thinks the
> > terminal can't handle colors and therefore the screenattr() function
> > returns 0. Alternatively one could set the MyGroup highlighting to
> > include some kind of term=bold (or similar, it is only necessary to be
> > different from the normal highlighting).
>
> For completeness, that would be that patch:
> diff --git a/src/testdir/test63.in b/src/testdir/test63.in
> --- a/src/testdir/test63.in
> +++ b/src/testdir/test63.in
> @@ -7,7 +7,7 @@ STARTTEST
> :" --- Check that "matcharg()" returns the correct group and pattern if a match
> :" --- is defined.
> :let @r = "*** Test 1: "
> -:highlight MyGroup1 ctermbg=red guibg=red
> +:highlight MyGroup1 term=bold ctermbg=red guibg=red
> :highlight MyGroup2 ctermbg=green guibg=green
> :highlight MyGroup3 ctermbg=blue guibg=blue
> :match MyGroup1 /TODO/

So this change replaces the other one, right?

--
"When I die, I want a tombstone that says "GAME OVER" - Ton Richters

[Christian Brabandt]

On Mo, 17 Nov 2014, Bram Moolenaar wrote:

>
> Christian wrote:
>
> > On Sa, 15 Nov 2014, Christian Brabandt wrote:
> >
> > > If I see this correctly, the failing part of test63 has been added with
> > > patch 7.4.330. I am pretty sure it fails, because vim thinks the
> > > terminal can't handle colors and therefore the screenattr() function
> > > returns 0. Alternatively one could set the MyGroup highlighting to
> > > include some kind of term=bold (or similar, it is only necessary to be
> > > different from the normal highlighting).
> >
> > For completeness, that would be that patch:
> > diff --git a/src/testdir/test63.in b/src/testdir/test63.in
> > --- a/src/testdir/test63.in
> > +++ b/src/testdir/test63.in
> > @@ -7,7 +7,7 @@ STARTTEST
> > :" --- Check that "matcharg()" returns the correct group and pattern if a match
> > :" --- is defined.
> > :let @r = "*** Test 1: "
> > -:highlight MyGroup1 ctermbg=red guibg=red
> > +:highlight MyGroup1 term=bold ctermbg=red guibg=red
> > :highlight MyGroup2 ctermbg=green guibg=green
> > :highlight MyGroup3 ctermbg=blue guibg=blue
> > :match MyGroup1 /TODO/
>
> So this change replaces the other one, right?

yes.

Mit freundlichen Grüßen
Christian
--

Spare jeden Pfennig, koste es was es wolle!