[vim/vim] Passing null_string as argument to substitute() in a def function crashes Vim (PR #18311)

[Yegappan Lakshmanan]

Fix the issue reported in #18309.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/18311

Commit Summary

• 7aba40a Passing null_string as argument to substitute() in a def function crashes Vim

File Changes

(2 files)

• M src/testdir/test_vim9_builtin.vim (43)
• M src/vim9expr.c (6)

Patch Links:

• https://github.com/vim/vim/pull/18311.patch
• https://github.com/vim/vim/pull/18311.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18311@github.com>

[zeertzjq]

zeertzjq left a comment (vim/vim#18311)

Perhaps there is a similar problem with searchpair() as well? NULL is not checked here:

	    // {skip} argument of searchpair() can be compiled if not empty
	    if (isn->isn_type == ISN_PUSHS && *isn->isn_arg.string != NUL)
		compile_string(isn, cctx, 0);

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18311/c3294589059@github.com>

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• 6af2b4f Fix a similar problem with the searchpair() function

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18311/before/7aba40a9a3556e35be9d2b8f26bc382cea01da1c/after/6af2b4fa50d0e011b21ffabeccf47ad835d115f7@github.com>

[Yegappan Lakshmanan]

yegappan left a comment (vim/vim#18311)

Perhaps there is a similar problem with searchpair() as well? NULL is not checked here:

	    // {skip} argument of searchpair() can be compiled if not empty
	    if (isn->isn_type == ISN_PUSHS && *isn->isn_arg.string != NUL)
		compile_string(isn, cctx, 0);

Yes. Thanks for noticing it. I have updated the PR with the fix for that also.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18311/c3294639038@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#18311)

thanks

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18311/c3300037166@github.com>

[Christian Brabandt]

Closed #18311 via afa2a81.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18311/issue_event/19734167698@github.com>