[vim/vim] :pythonx heredoc lines are parsed as Ex commands when skipping (PR #21422)
dkearns
What does this change do?
See commit message.
Commit message
Problem: :pythonx heredoc lines are parsed as Ex commands when skipping.
Solution: Consume the heredoc lines like the other :python commands, and
don't initialise 'pyxversion', when skipping. (Doug Kearns)
AI assistance
- No AI was used
Checklist
- The commit message follows the Problem/Solution form above
-
Signed-off-by:trailer is present - Tests were added
- No documentation update is needed
Anything reviewers should know
I'm aware of at least a dozen command skipping issues that I turned up when working on something a little while ago, and more have been introduced recently. I'll endeavour to tease them out over the next few days.
@chrisbra, I think the robustness of command skipping should have been better tested before :source-dryrun was merged. I'd consider backing it out but if that's going to cause too much of a kerfuffle it would be a good idea to add a warning in the help until it is more mature.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/21422
Commit Summary
- 40e0aa1 :pythonx heredoc lines are parsed as Ex commands when skipping
File Changes
(5 files)
- M src/ex_cmds2.c (3)
- M src/ex_docmd.c (4)
- M src/testdir/test_python2.vim (9)
- M src/testdir/test_python3.vim (9)
- M src/testdir/test_vimscript.vim (30)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.