Moving the new sodium crypto code to a separate file

[Yegappan Lakshmanan]

Hi,

The new sodium crypto related code is in the crypt.c file.
But the blowfish code is in the blowfish.c file and the zip
code is in the crypt_zip.c file. To be consistent, the sodium
related code should be moved to the crypt_sodium.c file?

Regards,
Yegappan

[Christian Brabandt]

I don't mind either way. I just kept it in crypt.c because there are
only a couple of wrapper functions around the actual sodium code.

Best,
Christian
--
Wie glücklich viele Menschen wären, wenn sie sich genausowenig um die
Angelegenheiten anderer kümmern würden wie um die eigenen.
-- Georg Christoph Lichtenberg

[Bram Moolenaar]

Christian wrote:

> On Di, 10 Aug 2021, Yegappan Lakshmanan wrote:
>
> > The new sodium crypto related code is in the crypt.c file.
> > But the blowfish code is in the blowfish.c file and the zip
> > code is in the crypt_zip.c file. To be consistent, the sodium
> > related code should be moved to the crypt_sodium.c file?
>
> I don't mind either way. I just kept it in crypt.c because there are
> only a couple of wrapper functions around the actual sodium code.

The blowfish.c and crypt_zip.c files contain the implementation of the
algorithm. For Sodium we don't have the implementation. This is fine
as it is. Also, the crypt.c file is not big, thus there is no good
reason to split it.

Generally, every file to be compiled has some overhead, making
compilation slower. Especially when compiling with a GUI (GTK header
files make compilate go a lot slower for me). Thus I don't like
splitting everything into tiny files.

--
CONCORDE: Quickly, sir, come this way!
LAUNCELOT: No! It's not right for my idiom. I must escape more ... more ...
CONCORDE: Dramatically, sir?
LAUNCELOT: Dramatically.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///