[vim/vim] Detect kitty key protocol on startup (PR #19600)
Foxe Chen
To be honest I do not get the point of the keyprotocol option, was it added because there wasn't way to detect KKP when Vim added support for it? Or is there some sort of gotcha that I am not aware of?
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19600
Commit Summary
- a70ce2a detect kitty key protocol on startup
File Changes
(2 files)
- M src/term.c (25)
- M src/testdir/test_termcodes.vim (27)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 0d1a087 detect kitty key protocol on startup
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19600)oh is it possible to detect this automatically? I wasn't aware of this
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 254715f detect kitty key protocol on startup
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 8641a04 detect kitty key protocol on startup
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19600)Thanks. can some kitty users try this out please?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19600)will this work correclty on GUI versions of Vim?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#19600)will this work correclty on GUI versions of Vim?
I am not sure what you mean. The kitty keyboard protocol is only for the terminal?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19600)yes, but we are not sending out those terminal sequences when we are not run in a terminal, are we?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- c81e717 detect kitty key protocol on startup
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#19600)I will close this PR. This automatic detection prevents the user from disabling the protocol. I don't think its worth the complexity.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Foxe Chen
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.