[vim/vim] make clipboard and ASCII NUL work better (#6312)

7 views
Skip to first unread message

Christian Brabandt

unread,
Jun 21, 2020, 3:30:35 PM6/21/20
to vim/vim, Subscribed

This is for fixing issue #6149

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/6312

Commit Summary

  • make clipboard and ASCII NUL work better

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

codecov[bot]

unread,
Jun 22, 2020, 4:02:38 AM6/22/20
to vim/vim, Subscribed

Codecov Report

Merging #6312 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@

##           master    #6312      +/-   ##

==========================================

- Coverage   87.65%   87.50%   -0.15%     

==========================================

  Files         143      143              

  Lines      158688   155922    -2766     

==========================================

- Hits       139091   136442    -2649     

+ Misses      19597    19480     -117
Impacted Files Coverage Δ
src/gui.c 62.77% <0.00%> (-1.25%) ⬇️
src/mbyte.c 78.64% <0.00%> (-1.23%) ⬇️
src/textobject.c 91.69% <0.00%> (-0.71%) ⬇️
src/search.c 90.79% <0.00%> (-0.67%) ⬇️
src/mouse.c 77.39% <0.00%> (-0.67%) ⬇️
src/move.c 87.55% <0.00%> (-0.66%) ⬇️
src/if_xcmdsrv.c 88.13% <0.00%> (-0.60%) ⬇️
src/ops.c 91.82% <0.00%> (-0.58%) ⬇️
src/scriptfile.c 90.78% <0.00%> (-0.55%) ⬇️
src/bufwrite.c 76.44% <0.00%> (-0.53%) ⬇️
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38041da...822a38f. Read the comment docs.

Bram Moolenaar

unread,
Jun 22, 2020, 2:27:02 PM6/22/20
to vim/vim, Subscribed

I'll include it, but it appears the test passes even without the code change.

Christian Brabandt

unread,
Jun 22, 2020, 2:29:49 PM6/22/20
to vim/vim, Subscribed

it should fail, it certainly did for me:

1 FAILED:
Found errors in Test_clipboard_nul():
Caught exception in Test_clipboard_nul(): Vim(normal):E353: Nothing in register * @ function RunTheTest[39]..Test_clipboard_nul, line 7

Bram Moolenaar

unread,
Jun 22, 2020, 2:31:18 PM6/22/20
to vim/vim, Subscribed

Closed #6312 via 25fd267.

Bram Moolenaar

unread,
Jun 22, 2020, 2:33:14 PM6/22/20
to vim/vim, Subscribed

on what OS did you test?

Christian Brabandt

unread,
Jun 22, 2020, 2:37:20 PM6/22/20
to vim/vim, Subscribed

Windows 10, built using Mingw 64bit. I suspect the appveyor test should fail with a similar message.

Bram Moolenaar

unread,
Jun 22, 2020, 4:12:46 PM6/22/20
to vim...@googlegroups.com, Christian Brabandt

Christian wrote:

> Windows 10, built using Mingw 64bit. I suspect the appveyor test
> should fail with a similar message.

Ah, I only tested on Linux. I suppose that version of the code was
already working.

--
Sorry, no fortune today.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Reply all
Reply to author
Forward
0 new messages