[vim/vim] Reversed text opacity in popup when termguicolor is set (PR #20284)

[Shad]

I've tried to fix the issue #20283 simply by reversing popup_color and base_fg when calling blend_colors(). It works but doing so, I got the same blending direction than in hl_pum_blend_attr() I'm afraid that I missed something when I see the comment stating that:

  /*
   * Blend for pum opacity space cells: keep underlying fg, blend bg.
   * This is different from hl_blend_attr(blend_fg=TRUE) where fg blends
   * in the wrong direction for pum use.
   */                                                                           

If the fix is ok, I'll look to add/update the tests

Before the patch
catppuccin-termguicolor.png (view on web)

After the patch
catppuccin-termguicolor-after-patch.png (view on web)

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20284

Commit Summary

• 9588033 Reversed text opacity in popup when termguicolor is set

File Changes

(1 file)

• M src/highlight.c (4)

Patch Links:

• https://github.com/vim/vim/pull/20284.patch
• https://github.com/vim/vim/pull/20284.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20284@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#20284)

Thanks, but I'd like to hear @mattn opinion on this first ?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20284/c4512439530@github.com>

[mattn]

mattn left a comment (vim/vim#20284)

As you said, it certainly looks like the degree of opacity is reversed. I'll check it.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20284/c4513686582@github.com>

[mattn]

mattn left a comment (vim/vim#20284)

LGTM. Please fix with comments to be first = 0% side, second = 100% side. Thanks

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20284/c4513757063@github.com>

[Shad]

@shadowwa pushed 1 commit.

• 1e72d12 update tests

—
View it on GitHub or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20284/before/95880330ecf7ff205fae669f844b4c94f44cf22c/after/1e72d12a16a9336e403f86f00092cf703ab11491@github.com>

[Shad]

shadowwa left a comment (vim/vim#20284)

LGTM. Please fix with comments to be first = 0% side, second = 100% side. Thanks

I'm sorry, I didn't quite get the comments you wanted me to fix.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20284/c4518364388@github.com>