[vim/vim] netrw 171 (regression?) LONGLIST file size column missing left-padding with spaces (Issue #10315)

[David Fong]

Yesterday I did an update from Ubuntu 21.10 to ubuntu 22.04. My vim got updated, and my netrw went from v170 to v171. With that change, I noticed that the LONGLIST format no longer left-pads the size information column with spaces to make each entry of the column the same width. It causes the entries of the time column to the right become unaligned. I made a feeble attempt to browse the netrw code. I am not familiar with vim scripting, so I might say or guess stuff that is wrong.

I did notice that the following definition of fsz (a left-padded-with-spaces) doesn't seem to be used? (I'm assuming the definition is scoped to the "if-block"). If it's intended to be used instead of sz, that could be why, in which case I wonder why fsz is defined before the following modification of sz in the case of human-readable units.

https://github.com/vim/vim/blob/202b4bd3a452898cfe3ed72facfbf7cb8199fa4b/runtime/autoload/netrw.vim#L11088

I'm not confident that this is actually the problem because the git blame of those lines says that they haven't been changed for several years.

Sorry if this is a noob issue. Let me know if there's any more information I can provide to help find out why this seems to have changed. I don't know how to go back at test the older version but I do have a screenshot.

before and after screenshots before:

after:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/10315@github.com>

[Bram Moolenaar]

@cecamp

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/10315/1113094742@github.com>

[David Fong]

I also noticed that if a file name is long (longer than around 32 characters), it overflows into the columns for file size and timestamp info, and then the file size and timestamp info get treated as part of the file name when opening the file, which creates a new file with that concatenated name instead of the intended file.

I suppose I should file a separate issue for this?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/10315/1196166578@github.com>

[Christian Brabandt]

Closed #10315 as completed via #12150.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issue/10315/issue_event/11033863013@github.com>