[vim/vim] runtime(xslt,xsd): speed up highlighting by removing backtracking from patterns (PR #20436)
Dmytro Meleshko
Scrolling in these filetypes is too slow, so I investigated which syntax patterns were causing the slowdown with :syntime. Turns out it was the matching of XSL/XSD-specific tag names was costing way more time than it has to. I fixed this with by using the lc=... parameter for the regexes, which makes the syntax engine step a number of characters back before matching the pattern, which in this case is practically equivalent to a lookbehind in front of the pattern. I also made them check the character before the name of the XML namespace which they weren't doing before, so that stuff like <notxsl:element>... does not get matched.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20436
Commit Summary
- 2c0ae3c runtime(xslt,xsd): speed up highlighting by removing backtracking from patterns
File Changes
(2 files)
- M runtime/syntax/xsd.vim (72)
- M runtime/syntax/xslt.vim (90)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
dkearns
dkearns left a comment (vim/vim#20436)Did you use lc=5 rather than \@5<= for performance or because you were unaware that lookbehinds could specify a byte limit? I'm mostly curious because lc is described as obsolete in the docs and while I haven't tested it in years it used to be about 2x faster than byte-limited lookbehinds. That was with regexpengine=1 but I imagine the difference is considerably greater with regexpengine=2.
It might be an idea to clarify the documentation at :help :syn-lc
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20436)Thanks, I include it
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Dmytro Meleshko
dmitmel left a comment (vim/vim#20436)@chrisbra Please wait before merging this patch
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Dmytro Meleshko
dmitmel left a comment (vim/vim#20436)I have some other changes that I want to make, but didn't have time to. Please confirm that you've seen this comment.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20436)okay, holding off then
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.