Commit: patch 9.1.1377: patch v9.1.1370 causes some GTK warning messages

1 view
Skip to first unread message

Christian Brabandt

unread,
May 10, 2025, 9:00:12 AM5/10/25
to vim...@googlegroups.com
patch 9.1.1377: patch v9.1.1370 causes some GTK warning messages

Commit: https://github.com/vim/vim/commit/d8ebccbb10623f7d73b27f77dedc47158a0e7110
Author: Drew Vogel <dvogel@github>
Date: Sat May 10 14:46:28 2025 +0200

patch 9.1.1377: patch v9.1.1370 causes some GTK warning messages

Problem: Some GTK3 users experienced unexpectedly small windows at
startup (after v9.1.1368, @berggeist, Tony Mechelynck)
Solution: Update window manager hints in gui_mch_open, partly revert
v9.1.1370 (Drew Vogel)

fixes: #17279
closes: #17288

Signed-off-by: Drew Vogel <dvogel@github>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/gui_gtk_x11.c b/src/gui_gtk_x11.c
index 762bdc1e5..c000a1181 100644
--- a/src/gui_gtk_x11.c
+++ b/src/gui_gtk_x11.c
@@ -4532,13 +4532,11 @@ gui_mch_open(void)
pixel_width = (guint)(gui_get_base_width() + Columns * gui.char_width);
pixel_height = (guint)(gui_get_base_height() + Rows * gui.char_height);

-# if !GTK_CHECK_VERSION(3,0,0)
// For GTK2 changing the size of the form widget doesn't cause window
// resizing.
if (gtk_socket_id == 0)
gtk_window_resize(GTK_WINDOW(gui.mainwin), pixel_width, pixel_height);
update_window_manager_hints(0, 0);
-# endif

if (foreground_argument != NULL)
fg_pixel = gui_get_color((char_u *)foreground_argument);
diff --git a/src/version.c b/src/version.c
index 7547f0a58..aa7f46180 100644
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1377,
/**/
1376,
/**/
Reply all
Reply to author
Forward
0 new messages