[vim/vim] GTK4: Implement command line arguments (PR #20847)

[Foxe Chen]

Updated docs and removed redundant code

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20847

Commit Summary

• 86cb3eb Implement command line arguments for GTK4 GUI

File Changes

(5 files)

• M runtime/doc/gui.txt (2)
• M runtime/doc/gui_x11.txt (16)
• M src/globals.h (2)
• M src/gui_gtk4.c (132)
• M src/main.c (12)

Patch Links:

• https://github.com/vim/vim/pull/20847.patch
• https://github.com/vim/vim/pull/20847.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20847@github.com>

[Foxe Chen]

64-bitman left a comment (vim/vim#20847)

THanks, can you please also update runtime/doc/vim.1 ?

Done

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20847/c5084210152@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#20847)

thanks

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20847/c5095864342@github.com>

[Foxe Chen]

64-bitman left a comment (vim/vim#20847)

Hm, no I am not sure this is quite right yet. The argument parsing loop looks wrong and seems to have some bugs (unless I am missing something):

1. Prefix matching: strncmp(s, "-fn", 3), -bg, -fg match any argument starting with those bytes
2. strncmp(s, "--prg-name", 8) compares 8 chars instead of 10.
3. The = form eats an argument. The strip logic sets n_strip = 2 whenever value != NULL, but for the -opt=val form the value is inside the same argv element, so it strips the flag and the following unrelated argument.
4. Next arg may be a flag. value = argv[i+1] isn't checked for being another option, so -fg -geometry 80x24 takes -geometry as the colour.

Issues should be fixed now. Used claude for the fix and reviewed it

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20847/c5096578243@github.com>