[vim/vim] `Command too recursive` when using minpac to install plugins (Issue #13732)

BenYip

unread,

Dec 19, 2023, 5:36:38 PM12/19/23

to vim/vim, Subscribed

Steps to reproduce

Use https://github.com/k-takata/minpac to manage plugins.
Run call minpac#update()

Expected behaviour

Plugins are successfully installed. Instead vim show errors Command too recursive.
This is because it use a lot of recursive callbacks and 2076463 (9.0.2103) set MAX_CALLBACK_DEPTH from 100 to 20.
Maybe provide an option to set its value instead of a hard-coded value?

Version of Vim

9.0.2103

Environment

doesn't matter

Logs and stack traces

Error detected while processing function <SNR>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_start_jo
]..<SNR>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_
rt_job[2]..<SNR>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_start_job[2]..<
>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_start_job[2]..<SNR>201_start_j

line    2:
E169: Command too recursive
Press ENTER or type command to continue
E169: Command too recursive
Press ENTER or type command to continue
E169: Command too recursive
Press ENTER or type command to continue

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

James McCoy

unread,

Dec 19, 2023, 7:37:54 PM12/19/23

to vim/vim, Subscribed

This is because it use a lot of recursive callbacks and 2076463 (9.0.2103) set MAX_CALLBACK_DEPTH from 100 to 20.

That patch can be reverted since the problem was root caused to something else, however it's probably still worth looking at making minipac not so recursive, if feasible.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

BenYip

unread,

Dec 19, 2023, 9:06:16 PM12/19/23

to vim/vim, Subscribed

@k-takata

This is because it use a lot of recursive callbacks and 2076463 (9.0.2103) set MAX_CALLBACK_DEPTH from 100 to 20.

That patch can be reverted since the problem was root caused to something else, however it's probably still worth looking at making minipac not so recursive, if feasible.

—

Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

K.Takata

unread,

Dec 20, 2023, 2:13:12 AM12/20/23

to vim/vim, Subscribed

I'm now updating minpac not to use recursive calls. k-takata/minpac#153

For Vim, it might be better to loosen the limit?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Dec 20, 2023, 2:45:48 AM12/20/23

to vim/vim, Subscribed

Yeah, since the problem patch 9.0.2103 wanted to fix was wrong, we may instead revert it (or instead increase reverse the callback function limit). What limit would be right for minpac then? 50? Or shall we go with 'maxfuncdepth' again?
Would you like to create a PR for that?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

K.Takata

unread,

Dec 20, 2023, 3:46:58 AM12/20/23

to vim/vim, Subscribed

Current implementation of minpac calls timer_start() inside from the timer callback and the depth of the recursive call may depend on the number of the plugins to be updated. So, I cannot tell the maximum depth.
Back to 'maxfuncdepth' should be okay.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Dec 21, 2023, 11:05:29 AM12/21/23

to vim/vim, Subscribed

Closed #13732 as completed via fe583b1.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward