[vim/vim] matchfuzzy() leaks allocated lists (PR #17980)
zeertzjq
Problem: matchfuzzy() leaks allocated lists (after 9.1.1627).
Solution: Restore the "retmatchpos" condition.
The memory leak cannot be caught by ASAN as the garbage collector still
tracks these lists, but it can be reproduced by the following script,
which increases Vim's memory usage to over 1 GiB without this fix:
for i in range(100000) call matchfuzzy([repeat('a', 300)], repeat('a', 257)) endfor
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/17980
Commit Summary
- 53507b5 matchfuzzy() leaks allocated lists
File Changes
(1 file)
- M src/fuzzy.c (4)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
zeertzjq left a comment (vim/vim#17980)cc @girishji
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
girish
girishji left a comment (vim/vim#17980)Thanks for fixing this. I believe it was leaking the lmatchpos list.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
@zeertzjq pushed 1 commit.
- 5e0f3a8 matchfuzzy() leaks allocated lists
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
zeertzjq
zeertzjq left a comment (vim/vim#17980)Closing in favor of #17984
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
Closed #17980.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.