[vim/vim] Combine highlighting for `numhl` when using multiples signs (Issue #16842)
Igor Lacerda
igorlfs created an issue (vim/vim#16842)Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
When multiple signs are placed on the same line, their numhl isn't combined: the sign with higher priority (or the last one) overwrites the numhl
Describe the solution you'd like
It should be possible to use combine the highlighting from multiple signs
Describe alternatives you've considered
N/A
Additional context
Related: neovim/neovim#27555
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Éric NICOLAS
ccjmne left a comment (vim/vim#16842)If I understand correctly, this request essentially asks for any higher- or equal-priority sign that currently would overwrite all properties (though specifically text/texthl vs numhl of a lower-priority sign, to instead "patch" its highlights onto the previous ones.
The idea would be to have a text+texthl-only sign work together with a numhl sign. This request is popular. I think it could be sensible.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Éric NICOLAS
ccjmne left a comment (vim/vim#16842)AFAICT, currently, equal-priority signs do get their properties merged, but in the case of, say, @yegappan's (excellent) LSP plug-in, signs may be emitted with various priorities according to the severity of the corresponding diagnostic.
If we are to set, say, some VCS signs with numhl to the same priority as LSP's error-level, we'll get both the Error indicator in the signs column, as well as the VCS colouring of the line number. However, in that case, if LSP were to emit only a Warning; we get only the VCS highlighting of the line number, and nothing in the gutter from LSP.
I do not know how to implement this most adequately without possibly ending up with some Frankenstein-like patchwork of linehl, numhl, culhl, texthl. What sort of configuration would Vim offer?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Igor Lacerda
igorlfs left a comment (vim/vim#16842)If I understand correctly, this request essentially asks for any higher- or equal-priority sign that currently would overwrite all properties
Honestly, I don't recall this request's original context, it's probably a situation that no longer bothers me 🤷🏼
Feel free to own it in any way.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.