[vim/vim] Correctly handle precedes char in list mode for long lines (#4953)

23 views
Skip to first unread message

Christian Brabandt

unread,
Sep 18, 2019, 4:44:34 AM9/18/19
to vim/vim, Subscribed

The 'precedes' value for the listchars option should only be drawn when
the list option is on and wrapping is off (and there is text preceeding
the first column) OR when list option is on and wrapping is on and the
line is longer than the complete window (and there is still text
preceeding the first column). But in the latter case, only
draw the precedes value in the first column visible for the physical
line, not in every first column of the screen line.

Add a test to verify the behaviour.

related: neovim/neovim#11034

(Note: the change to view_util is actually unrelated, but makes debugging
easier as the window size does not change unexpectedly when trying to
run the test interactively and switching between windows).


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/4953

Commit Summary

  • Correctly handle precedes char in list mode for long lines

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub

Bram Moolenaar

unread,
Sep 20, 2019, 11:00:54 AM9/20/19
to vim/vim, Subscribed

Closed #4953 via bffba7f.

Justin M. Keyes

unread,
Sep 21, 2019, 11:13:44 PM9/21/19
to vim/vim, Subscribed

Zach Wegner (neovim/neovim#11034) should have been credited.

Christian Brabandt

unread,
Sep 22, 2019, 1:43:57 AM9/22/19
to vim/vim, Subscribed
I did mention the neovim issue


> Am 22.09.2019 um 05:13 schrieb Justin M. Keyes <notifi...@github.com>:
>
> Zach Wegner (neovim/neovim#11034) should have been credited.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.


You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub, or mute the thread.

Wang Shidong

unread,
Feb 22, 2020, 8:05:53 AM2/22/20
to vim/vim, Subscribed

@brammool This PR is merged without included origin patch author Zach Wegner?


You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub, or unsubscribe.

Christian Brabandt

unread,
Feb 22, 2020, 8:16:02 AM2/22/20
to vim...@googlegroups.com
Most of the patch contains test cases, which came from me.

Am 22.02.2020 um 14:05 schrieb Wang Shidong (Vim Github Repository) <vim-dev...@256bit.org>:



@brammool This PR is merged without included origin patch author Zach Wegner?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/4953/c589954433%40github.com.

Christian Brabandt

unread,
Feb 22, 2020, 8:18:12 AM2/22/20
to vim/vim, Subscribed
Most of the patch contains test cases, which came from me.

> Am 22.02.2020 um 14:05 schrieb Wang Shidong <notifi...@github.com>:
>
> 
> @brammool This PR is merged without included origin patch author Zach Wegner?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or unsubscribe.


You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub, or unsubscribe.

Bram Moolenaar

unread,
Feb 22, 2020, 9:53:34 AM2/22/20
to vim/vim, Subscribed

It is mentioned in doc/version8.txt


You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub, or unsubscribe.

Reply all
Reply to author
Forward
0 new messages