[vim/vim] If session restored a tiny window, restore fails (PR #20692)
Illia Bobyr
Problem: If session restored a tiny window, restore fails Solution: Extend window sizes to be at least the minimum size during
session restore
If session contains a window that is shorter/narrower than the current &winminheight and &winminwidth, respectively, Vim will fail when assigning original values to the &winminheight/&winminwidth and the session restore will be slightly incomplete.
It seems reasonable to assume that if the user has selected certain values for these minimum size settings, it is safe to just make the restored windows big enough to match the minimums and continue without producing an error.
This fix allows Test_mksession_winminheight() to start with the default values of &winheight/&winwidth and only change them after the session restore.
Reviewer note.
Due to changes in the same test, it might be easier to wait for #20691 to be merged in first.
I'll resolve the conflicts and will publish this PR again then.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20692
Commit Summary
- d2b2885 If session restored a tiny window, restore fails
File Changes
(2 files)
- M src/session.c (9)
- M src/testdir/test_mksession.vim (6)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.