[vim/vim] fix: gf maybe hang and fail (PR #17970)

Shane-XB-Qian

unread,

Aug 11, 2025, 12:17:40 PMAug 11

to vim/vim, Subscribed

searching '**' maybe terrible slow
searching '**/plugin/' maybe fail

fix: #17881 (comment)

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/17970

Commit Summary

10c3999 fix: gf maybe hang and fail

File Changes

(1 file)

M runtime/autoload/vim.vim (9)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Aug 11, 2025, 2:39:28 PMAug 11

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#17970)

@lacygoill any comment?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

lacygoill

unread,

Aug 12, 2025, 4:00:23 AMAug 12

to vim/vim, Subscribed

lacygoill left a comment (vim/vim#17970)

I quickly tested the code, and it works.
I read it too, and findfile() coupled with getcompletion()'s runtime seems more effecient than **.
Thank you very much @Shane-XB-Qian for improving the code.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Aug 12, 2025, 3:19:38 PMAug 12

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#17970)

Thanks, I include it and also rename the plugin to vimgoto. Seems more appropriate than the generic vim.vim

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Aug 12, 2025, 3:36:57 PMAug 12

to vim/vim, Subscribed

Closed #17970.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Aug 12, 2025, 3:36:58 PMAug 12

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#17970)

included as of 639d93f

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Shane-XB-Qian

unread,

Aug 13, 2025, 4:46:29 AMAug 13

to vim/vim, Subscribed

Shane-XB-Qian left a comment (vim/vim#17970)

Thanks, I include it and also rename the plugin to vimgoto. Seems more appropriate than the generic vim.vim. I also noticed, it vimgoto does not handle the : consistently. I'll also fix this while merging down. Thanks all!

somehow even that renamed to vimgoto.vim, looks it still maybe conflict?
anyway, as for the ptn, i opened #17983 to make the name extraction a bit flexible