Cannot build "small" gvim on Windows

20 views
Skip to first unread message

Michael Soyka

unread,
May 17, 2020, 8:37:10 PM5/17/20
to vim_dev
Vim developers,

When I try to build gvim on Wiindows XP using mingw with FEATURES=SMALL, I get "windowsVersion undeclared" on line 839 of file os_win32.c.  This variable is instantiated in globals.h but only if FEAT_EVAL is defined and this happens only for NORMAL builds. 

The compilation error goes away and the test suite passes if the "windowsVersion" variable is moved out of the ifdef-block but I'm not experienced enough to know if that is the right thing to do so I defer to others for a patch. 

- mike

Ken Takata

unread,
May 17, 2020, 11:15:56 PM5/17/20
to vim_dev
Hi,
"windowsVersion" is used only in the windowsversion() function.
So, I think that the attached patch is better.

Regards,
Ken Takata
windowsVersion.diff

Michael Soyka

unread,
May 18, 2020, 9:37:54 AM5/18/20
to vim_dev
Hi Ken,

I agree that your solution is the correct one since the variable "windowsVersion" is used by the Vim builtin function windowsversion() which requires  feature EVAL (I missed that). 

Related to this topic, I see that windowsversion() is not listed in the help files under either ":help function-list" or ":help functions".  Just thought I'd mention it.

- mike
 
Reply all
Reply to author
Forward
0 new messages