[vim/vim] runtime(odin): fix indent issue/add test (PR #20658)
Maxim Kim
following odin code is incorrectly indented:
...
fmt.println("Hellope")
}
// Fallthrough statement
// fallthrough can be used to explicitly fall through into the next case block:
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20658
Commit Summary
File Changes
(3 files)
- M runtime/indent/odin.vim (10)
- A runtime/indent/testdir/odin.in (2631)
- A runtime/indent/testdir/odin.ok (2631)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Maxim Kim
habamax left a comment (vim/vim#20658)Are indent tests the part of the whole testing suite or they need to be run manually?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Maxim Kim
habamax left a comment (vim/vim#20658)note, there are still minor issues with indenting of the hanging comments, I will address them in other PRs when I have time.
Example:
z: f64 // `z` is typed of type `f64` (64-bit floating point number)
z = 1 // `1` is an untyped integer literal which can be implicitly converted to `f64`
// No need for any suffixes or decimal places like in other languages
// (with the exception of negative zero, which must be given as `-0.0`)
// CONSTANTS JUST WORK!!!
// Assignment statements
h: int = 123 // declares a new variable `h` with type `int` and assigns a value to it
h = 637 // assigns a new value to `h`
vs
z: f64 // `z` is typed of type `f64` (64-bit floating point number)
z = 1 // `1` is an untyped integer literal which can be implicitly converted to `f64`
// No need for any suffixes or decimal places like in other languages
// (with the exception of negative zero, which must be given as `-0.0`)
// CONSTANTS JUST WORK!!!
// Assignment statements
h: int = 123 // declares a new variable `h` with type `int` and assigns a value to it
h = 637 // assigns a new value to `h`
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
dkearns
dkearns left a comment (vim/vim#20658)Are indent tests the part of the whole testing suite
Yes, your change is good to go.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.