[vim/vim] Add command line completion support for :breakadd and :breakdel commands (PR #9950)

10 views
Skip to first unread message

Yegappan Lakshmanan

unread,
Mar 14, 2022, 12:29:19 AM3/14/22
to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/9950

Commit Summary

  • b88518c Add command line completion support for :breakadd and :breakdel commands

File Changes

(5 files)

Patch Links:

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9950@github.com>

Yegappan Lakshmanan

unread,
Mar 14, 2022, 12:36:07 AM3/14/22
to vim/vim, Push

@yegappan pushed 1 commit.

  • a4f17d3 Fix integer/long comparison warning in spellsuggest.c

—
View it on GitHub.


Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9950/push/9341982430@github.com>

codecov[bot]

unread,
Mar 14, 2022, 12:44:04 AM3/14/22
to vim/vim, Subscribed

Codecov Report

Merging #9950 (a4f17d3) into master (5c68617) will increase coverage by 4.90%.
The diff coverage is 92.10%.

Impacted file tree graph

@@            Coverage Diff             @@

##           master    #9950      +/-   ##

==========================================

+ Coverage   75.93%   80.84%   +4.90%     

==========================================

  Files         151      152       +1     

  Lines      146483   174272   +27789     

  Branches    38160    39514    +1354     

==========================================

+ Hits       111235   140882   +29647     

+ Misses      23518    20742    -2776     

- Partials    11730    12648     +918
Flag Coverage Δ
huge-clang-none 82.30% <94.59%> (?)
huge-gcc-unittests 2.01% <0.00%> (?)
linux 80.84% <92.10%> (?)
mingw-x64-HUGE ?
mingw-x64-HUGE-gui ?
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/usercmd.c 89.44% <ø> (-0.25%) ⬇️
src/cmdexpand.c 86.98% <91.89%> (-0.67%) ⬇️
src/spellsuggest.c 88.19% <100.00%> (+0.14%) ⬆️
src/gui_xim.c 21.35% <0.00%> (-63.83%) ⬇️
src/typval.c 84.35% <0.00%> (-9.16%) ⬇️
src/arabic.c 84.78% <0.00%> (-7.33%) ⬇️
src/vim9instr.c 75.79% <0.00%> (-7.26%) ⬇️
src/regexp_bt.c 78.25% <0.00%> (-6.79%) ⬇️
src/vim9execute.c 81.69% <0.00%> (-5.79%) ⬇️
src/vim9cmds.c 84.71% <0.00%> (-4.63%) ⬇️
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c68617...a4f17d3. Read the comment docs.

—
Reply to this email directly, view it on GitHub, or unsubscribe.


Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9950/c1066336140@github.com>

Yegappan Lakshmanan

unread,
Mar 14, 2022, 12:53:00 AM3/14/22
to vim/vim, Push

@yegappan pushed 1 commit.

—
View it on GitHub.


Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9950/push/9342054503@github.com>

Yegappan Lakshmanan

unread,
Mar 14, 2022, 10:30:38 AM3/14/22
to vim/vim, Push

@yegappan pushed 1 commit.

  • ce96e71 test_writefile test leaves a backup file in the home directory

—
View it on GitHub.


Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9950/push/9346758329@github.com>

Yegappan Lakshmanan

unread,
Mar 14, 2022, 11:31:28 AM3/14/22
to vim/vim, Push

@yegappan pushed 1 commit.

  • 2bfc239 skip the extra space characters if specified before doing the completion

—
View it on GitHub.


Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9950/push/9347434506@github.com>

lacygoill

unread,
Mar 14, 2022, 1:45:22 PM3/14/22
to vim/vim, Subscribed

Thank you very much for implementing this.

Relevant todo item:

Implement completion for "breakadd". Should expand the second argument, e.g.
"func", and then function names after ":breakadd func". Including
script-local functions.
Also for ":profile".

At some point, it would be nice to also provide completions for :profile file and :profile func.

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9950/c1067110259@github.com>

Yegappan Lakshmanan

unread,
Mar 14, 2022, 2:39:22 PM3/14/22
to vim/vim, Push

@yegappan pushed 1 commit.

  • 09e3aac Fix test failure in Cirrus-CI

—
View it on GitHub.


Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9950/push/9349164322@github.com>

Yegappan Lakshmanan

unread,
Mar 14, 2022, 2:52:24 PM3/14/22
to vim/vim, Push

@yegappan pushed 1 commit.

  • 029eb10 Add command line completion support for :breakadd and :breakdel commands

—
View it on GitHub.


Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9950/push/9349271490@github.com>

Bram Moolenaar

unread,
Mar 14, 2022, 3:25:40 PM3/14/22
to vim/vim, Subscribed

Closed #9950 via 6e2e2cc.

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9950/issue_event/6238133319@github.com>

Yegappan Lakshmanan

unread,
Mar 14, 2022, 11:36:39 PM3/14/22
to vim_dev, reply+ACY5DGAWWMO6PQEYL6...@reply.github.com, vim/vim, Subscribed
Hi,

On Mon, Mar 14, 2022 at 10:45 AM lacygoill <vim-dev...@256bit.org> wrote:

Thank you very much for implementing this.

Relevant todo item:

Implement completion for "breakadd". Should expand the second argument, e.g.
"func", and then function names after ":breakadd func". Including
script-local functions.
Also for ":profile".

At some point, it would be nice to also provide completions for :profile file and :profile func.




- Yegappan

vim-dev ML

unread,
Mar 14, 2022, 11:36:56 PM3/14/22
to vim/vim, vim-dev ML, Your activity

Hi,

On Mon, Mar 14, 2022 at 10:45 AM lacygoill ***@***.***>

wrote:

> Thank you very much for implementing this.
>
> Relevant todo item:
>
> Implement completion for "breakadd". Should expand the second argument,
> e.g.
> "func", and then function names after ":breakadd func". Including
> script-local functions.
> Also for ":profile".
>
> At some point, it would be nice to also provide completions for :profile
> file and :profile func.
>
>
>
Created PR https://github.com/vim/vim/pull/9955 for this.

- Yegappan

—
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/9950/c1067528402@github.com>

Reply all
Reply to author
Forward
0 new messages