[vim/vim] runtime(beancount): add language files (PR #20373)
Bruno BELANYI
Problem: beancount is recognized, but otherwise inert
Solution: import the filetype, syntax, indent, and compiler files from vim-beancount.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20373
Commit Summary
- 93ccae9 runtime(beancount): add language files
File Changes
(4 files)
- A runtime/compiler/bean_check.vim (15)
- A runtime/ftplugin/beancount.vim (11)
- A runtime/indent/beancount.vim (46)
- A runtime/syntax/beancount.vim (94)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Bruno BELANYI
ambroisie left a comment (vim/vim#20373)This is taken from https://github.com/nathangrigg/vim-beancount, hence why I set @nathangrigg as the author.
It does not include the omnifunc setting, mostly because I wasn't sure if Vim usually sets it unconditionally in its built-in filetypes.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Mao-Yining
mao-yining left a comment (vim/vim#20373)Please Update MAINTAINER file
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20373)Thanks, but do we really need those autoloaded functions here in the Vim tree? I am not sure how popular beancount is, well it doesn't seem to be for me. So I'd suggest just importing the indent, syntax and ftplugin and leave the rest as a separate plugin
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Mao-Yining
mao-yining left a comment (vim/vim#20373)Apart from bean count. There also has some similar project and need has similar stars. Like ledger cli and hledger. That is hard to say whether include things in autoload is a good idea.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Bruno BELANYI
ambroisie left a comment (vim/vim#20373)Thanks, but do we really need those autoloaded functions here in the Vim tree? I am not sure how popular beancount is, well it doesn't seem to be for me. So I'd suggest just importing the indent, syntax and ftplugin and leave the rest as a separate plugin
Sure, I don't really have a strong opinion either way, as noted in my first comment I initially uploaded without them.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
dkearns
dkearns left a comment (vim/vim#20373)This is taken from https://github.com/nathangrigg/vim-beancount, hence why I set @nathangrigg as the author.
Did you seek approval from the author for inclusion in the Vim runtime? Even if licensing allows it we generally like to have approval from the original author. There can be negative consequences for the main project from partial distribution with Vim.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Bruno BELANYI
ambroisie left a comment (vim/vim#20373)Yes, I reached out to him privately, he gave his approval.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20373)@nathangrigg can you please confirm and give public approval here? Thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Nathan Grigg
nathangrigg left a comment (vim/vim#20373)You have my approval, thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.