[vim/vim] Farewall to Bram and dedicate upcoming Vim 9.1 to him (PR #12749)
Christian Brabandt
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/12749
Commit Summary
- 458d1bb Farewall to Bram
File Changes
(1 file)
- M runtime/doc/version9.txt (8)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra pushed 1 commit.
- 025db31 Dedicate upcoming Vim 9.1 to Bram
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Codecov Report
Merging #12749 (025db31) into master (84bc00e) will decrease coverage by
0.01%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #12749 +/- ## ========================================== - Coverage 82.10% 82.09% -0.01% ========================================== Files 160 160 Lines 193690 193690 Branches 43492 43492 ========================================== - Hits 159025 159007 -18 - Misses 21819 21836 +17 - Partials 12846 12847 +1
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | 82.71% <ø> (-0.02%) |
⬇️ |
| linux | 82.71% <ø> (-0.02%) |
⬇️ |
| mingw-x64-HUGE | 76.61% <ø> (+<0.01%) |
⬆️ |
| mingw-x86-HUGE | 77.09% <ø> (-0.01%) |
⬇️ |
| windows | 78.20% <ø> (-0.01%) |
⬇️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
see 14 files with indirect coverage changes
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
@yegappan commented on this pull request.
> @@ -43,6 +43,17 @@ when the release was being prepared. Sven was a long time supporter of Vim. He registered the vim.org domain and created the first Vim website. We will remember him! + *Bram-Moolenaar* *Bram* +Vim version 9.1 is dedicated to Bram Moolenaar, who passed away August 3rd 2023
"who passed away on"?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
cvwillegen
@cvwillegen commented on this pull request.
> @@ -43,6 +43,17 @@ when the release was being prepared. Sven was a long time supporter of Vim. He registered the vim.org domain and created the first Vim website. We will remember him! + *Bram-Moolenaar* *Bram* +Vim version 9.1 is dedicated to Bram Moolenaar, who passed away August 3rd 2023
I would suggest "who passed away August 3rd, 2023". The "on" is optional to my (non-native) eyes.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
I have slightly updated it according to the suggestions, and replaced Brams email address in a few more places (e.g. the license and for reporting bugs). Hope you all find that okay.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
K.Takata
@k-takata commented on this pull request.
> @@ -43,6 +43,17 @@ when the release was being prepared. Sven was a long time supporter of Vim. He registered the vim.org domain and created the first Vim website. We will remember him! + *Bram-Moolenaar* *Bram* +Vim version 9.1 is dedicated to Bram Moolenaar, who passed away August 3rd 2023
You mean adding "," between the date and the year?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Goomba
@GoombaProgrammer commented on this pull request.
> @@ -43,6 +43,17 @@ when the release was being prepared. Sven was a long time supporter of Vim. He registered the vim.org domain and created the first Vim website. We will remember him! + *Bram-Moolenaar* *Bram* +Vim version 9.1 is dedicated to Bram Moolenaar, who passed away August 3rd 2023
@k-takata he means remove the word "on"
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
K.Takata
@k-takata commented on this pull request.
In runtime/autoload/ccomplete.vim:
> +# Maintainer: The Vim Project <https://github.com/vim/vim> +# Former Maintainer: Bram Moolenaar <Br...@vim.org>⬇️ Suggested change
-# Maintainer: The Vim Project <https://github.com/vim/vim> -# Former Maintainer: Bram Moolenaar <Br...@vim.org> +# Maintainer: The Vim Project <https://github.com/vim/vim> +# Former Maintainer: Bram Moolenaar <Br...@vim.org>
How about aligning "Language:", "Maintainer:" and "Last Change:"?
Not sure if "Former Maintainer:" should be also aligned.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
MC Naveen
@mcnaveen commented on this pull request.
> @@ -43,6 +43,17 @@ when the release was being prepared. Sven was a long time supporter of Vim. He registered the vim.org domain and created the first Vim website. We will remember him! + *Bram-Moolenaar* *Bram* +Vim version 9.1 is dedicated to Bram Moolenaar, who passed away August 3rd 2023
English is not my native language. I suggest.
Vim version 9.1 is dedicated to Bram Moolenaar, who passed away
onAugust 3rd 2023
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra commented on this pull request.
In runtime/autoload/ccomplete.vim:
> +# Maintainer: The Vim Project <https://github.com/vim/vim> +# Former Maintainer: Bram Moolenaar <Br...@vim.org>
okay, will adjust later.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
are we okay including this?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Devin Weaver
> +# Maintainer: The Vim Project <https://github.com/vim/vim>
Shane-XB-Qian
// bram used to announce something via vim_announce, (not much people in vim_dev for some reason seems e.g dup mails from itself and github), we may should keep that tradition as well.
--
shane.xb.qian
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
> I’m curious, with “The Vim Project” pointing to github will
> contributions still be available via email patches to vim...@vim.org?
However, creating PRs is prefered for the following reasons:
- it runs the CI test suite
- they do not get lost so easily
- you need to be subscribed to the vim-dev mailing list
Thanks,
Chris
Christian Brabandt
Merged #12749 into master.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Shane-XB-Qian
--
shane.xb.qian
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
--
shane.xb.qian
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Restorer
@RestorerZ commented on this pull request.
In src/message.c:
> @@ -1114,7 +1114,7 @@ ex_messages(exarg_T *eap)
msg_attr(
// Translator: Please replace the name and email address
// with the appropriate text for your translation.
- _("Messages maintainer: Bram Moolenaar <Br...@vim.org>"),
+ _("Messages maintainer: The Vim Project"),
Maybe you should add an email address vim...@vim.org
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yee Cheng Chin
This change modified the Vim license file. I'm just assuming that's an ok thing to do (was previously going to ask about this on a separate discussion as license issues can be tricky), but wondering if this affects other things like the GitHub license detection (it still seems to work so far), and the spdx entry: https://spdx.org/licenses/Vim.html, as well as https://vim-license.dev/.
Pinging @othree who filed #5458 and also did a lot of work on getting the Vim license recognized.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
othree
Thanks for pinging me, I can help to communicate and send the PR. There are two major repos we need to send PR:
- SPDX
- choosealicense, which is the source for license recognization.
But I think it will cause some issue if we change the text in choosealicense directly. Which will cause the existing repo uses the Vim license to become unrecognized. The ideal case is we have a new version of the license, such as Vim License 1.1. Then we didn't need to worry the existing repo affected. But it also will cause another issue. The choosealicense only accepts widely used license. Vim License 1.1 will be a new license and is not widely used at this moment. So there will be a period of time that GitHub won't recognize it.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yee Cheng Chin
When you say "existing repo", do you mean this one itself (https://github.com/vim/vim/)? It seems like GitHub is still recognizing it despite this PR being merged already, but I wonder if there is a time delay in rescanning done by GitHub. If that's the case that means GitHub will soon stop recognizing the license?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
othree
The "existing repo" means every repo uses Vim License such as "tpope/vim-pathogen". "vim/vim" is one of them. I will try to verify my assumption later(maybe next week). GitHub has a special cache for the result of license detection. So it is possible that the license result is not changed now. I am not sure when it will be invalid.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
I was a bit hesitant to change the license file directly, but I did not see any alternatives. Surely, just changing the maintainer line should be allowed and okay, since we did not touch the actual license clauses. But if you think of a different solution, please let me know.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
othree
A quick update:
The Licensee can recognize the new version of the Vim License text
The similarity is 98.45%. The threshold is 98%, so there is not much space for other differences. I will spend some time checking other projects using the Vim License and have the software name correctly modified. Currently, I feel positive about the results. It seems Licensee has a better algorithm to compare the license text with substitutions than before.
If the result is good. We don't need to worry about the existing software in the wild. We just need to:
- Discuss how to deal with this case with the SPDX
- Update the license text or create a new version of the license based on the answer of 1
- Update the license text on choosealicense.com if necessary
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
that are good news, thanks!
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.