[vim/vim] Remove VIM_BACKTICK (PR #19562)
Martin Tournoij
This would only be unset on the tiny build, but all the cases of #ifdef VIM_BACKTICK are in features already excluded in the tiny build, so effectively it doesn't really seem to do anything.
The byte size doesn't increase; before (--with-features=tiny):
1,724,264 │ 13:43 │ /tmp/vim-sz-before/tiny-O2
1,484,552 │ 13:44 │ /tmp/vim-sz-before/tiny-Os
After, exactly the same size:
1,724,264 │ 13:55 │ /tmp/vim-sz-after/tiny-O2
1,484,552 │ 13:55 │ /tmp/vim-sz-after/tiny-Os
Saves a few #ifdefs.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19562
Commit Summary
- 4db974b Remove VIM_BACKTICK
File Changes
(5 files)
- M src/feature.h (4)
- M src/filepath.c (7)
- M src/misc1.c (3)
- M src/os_amiga.c (8)
- M src/os_mswin.c (8)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19562)thanks, that is fine I think
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19562)Hm, actually that doesn't seem to be true. If I read filepath.c correctly, the ifdef VIM_BACKTICK is actually protecting some code from being included in tiny vims. In my case, this is a vim.tiny with GTK3 version:
-rwxrwxr-x 1 chrisbra chrisbra 7912952 Mar 3 21:01 vim.tiny.after
-rwxrwxr-x 1 chrisbra chrisbra 7910616 Mar 3 21:02 vim.tiny.before
Compiled using: -g -O2 -D_REENTRANT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1. Not that it is that much of a difference, only about 0.29‰ promille.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.