[vim/vim] GNU make syntax regression (Issue #18890)

[inzeets]

inzeets created an issue (vim/vim#18890)

Steps to reproduce

Before 2a33b49:
image.png (view on web)

After:
image.png (view on web)

Expected behaviour

image.png (view on web)

Version of Vim

VIM - Vi IMproved 9.1 (2024 Jan 02, compiled Nov 08 2025 17:20:55) Included patches: 1-1900 Compiled by Homebrew

Environment

Ubuntu 24.04
xterm-256color

Logs and stack traces

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/18890@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#18890)

ping @rohieb @littlewu2508

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/18890/3632025765@github.com>

[littlewu2508]

littlewu2508 left a comment (vim/vim#18890)

Thanks for the good catch.

Seems like the problem can be solved by

--- a/runtime/syntax/make.vim
+++ b/runtime/syntax/make.vim
@@ -40,10 +40,6 @@ syn match makeIdent  "\$\$\w*"
 syn match makeIdent    "\$\$\$\$\w*" containedin=makeDefine
 syn match makeIdent    "\$[^({]"
 syn match makeIdent    "\$\$[^({]" containedin=makeDefine
-syn match makeIdent    "^ *[^:#= \t]*\s*[:+?!*]="me=e-2
-syn match makeIdent    "^ *[^:#= \t]*\s*::="me=e-3
-syn match makeIdent    "^ *[^:#= \t]*\s*="me=e-1
-syn match makeIdent    "%"
 if get(b:, 'make_flavor', s:make_flavor) == 'microsoft'
   syn region makeIdent start="\$(" end=")" contains=makeStatement,makeIdent
   syn region makeIdent start="\${" end="}" contains=makeStatement,makeIdent
@@ -55,6 +51,10 @@ else
   syn region makeIdent start="\$\$(" skip="\\)\|\\\\" end=")" containedin=makeDefine contains=makeStatement,makeIdent
   syn region makeIdent start="\$\${" skip="\\}\|\\\\" end="}" containedin=makeDefine contains=makeStatement,makeIdent
 endif
+syn match makeIdent    "^ *[^:#= \t]*\s*[:+?!*]="me=e-2
+syn match makeIdent    "^ *[^:#= \t]*\s*::="me=e-3
+syn match makeIdent    "^ *[^:#= \t]*\s*="me=e-1
+syn match makeIdent    "%"

which partially revert 2a33b49

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/18890/3633179172@github.com>

[Christian Brabandt]

Closed #18890 as completed via aded554.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issue/18890/issue_event/21732834683@github.com>