[vim/vim] filetype: starlark files are not recognized (PR #18807)

10 views
Skip to first unread message

Bruno BELANYI

unread,
Nov 25, 2025, 6:47:27 AM (5 days ago) Nov 25
to vim/vim, Subscribed

Problem: Starlark (previously Skylark) files are not recognized.
Solution: Detect both as bzl (Vim's name for this filetype).


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/18807

Commit Summary

  • fd912af filetype: starlark files are not recognized

File Changes

(2 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18807@github.com>

dkearns

unread,
Nov 25, 2025, 6:51:24 AM (5 days ago) Nov 25
to vim/vim, Subscribed

@dkearns requested changes on this pull request.

Thanks. These changes should go in runtime/autoload/dist/ft.vim now.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18807/review/3504723141@github.com>

Bruno BELANYI

unread,
Nov 25, 2025, 6:58:40 AM (5 days ago) Nov 25
to vim/vim, Push

@ambroisie pushed 1 commit.

  • cc4b2d5 filetype: skylark files are not recognized


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18807/before/fd912af10bdb89147280f6c920271373e6752e5f/after/cc4b2d554052c2d2602f85a29804102316ca4576@github.com>

Bruno BELANYI

unread,
Nov 25, 2025, 7:00:41 AM (5 days ago) Nov 25
to vim/vim, Subscribed
ambroisie left a comment (vim/vim#18807)

@dkearns done.


I noticed that starlark is used in ftdetect, but there are no ftplugin files for this filetype. Should there be shim which sources bzl's?


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18807/c3575302564@github.com>

Christian Brabandt

unread,
Nov 27, 2025, 3:48:12 PM (2 days ago) Nov 27
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#18807)

Is this correct?

A quick google search suggests, that *.sky is used for a few different file types> https://file.org/extension/sky
And also I couldn't find some references to *.skylark files. So do you have any references?


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18807/c3587236772@github.com>

Bruno BELANYI

unread,
Nov 27, 2025, 4:45:53 PM (2 days ago) Nov 27
to vim/vim, Subscribed
ambroisie left a comment (vim/vim#18807)

@chrisbra I know for sure that sky is used. I added skylark to mirror with star and starlark, though I've never seen the latter being used.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18807/c3587342760@github.com>

Christian Brabandt

unread,
Nov 27, 2025, 5:17:07 PM (2 days ago) Nov 27
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#18807)

Can you mention a reference for this please?


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18807/c3587408929@github.com>

Bruno BELANYI

unread,
Nov 27, 2025, 5:50:42 PM (2 days ago) Nov 27
to vim/vim, Subscribed
ambroisie left a comment (vim/vim#18807)

For .sky? https://docs.bazel.build/versions/0.17.1/skylark/spec.html still refers to it in some examples (Ctrl-f a.sky)


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18807/c3587449698@github.com>

Christian Brabandt

unread,
Nov 28, 2025, 3:46:52 PM (yesterday) Nov 28
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#18807)

okay thanks. Then let me just include the *.sky thing.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18807/c3590407740@github.com>

Christian Brabandt

unread,
Nov 28, 2025, 3:52:53 PM (yesterday) Nov 28
to vim/vim, Subscribed

Closed #18807 via 3ba6a97.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18807/issue_event/21247953102@github.com>

dkearns

unread,
12:13 AM (22 hours ago) 12:13 AM
to vim/vim, Subscribed
dkearns left a comment (vim/vim#18807)

https://github.com/search?q=path%3A*.skylark&type=code returns 2 files


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18807/c3591002453@github.com>

Reply all
Reply to author
Forward
0 new messages