Problem: Starlark (previously Skylark) files are not recognized.
Solution: Detect both as bzl (Vim's name for this filetype).
https://github.com/vim/vim/pull/18807
(2 files)
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
@dkearns requested changes on this pull request.
Thanks. These changes should go in runtime/autoload/dist/ft.vim now.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.![]()
@ambroisie pushed 1 commit.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.![]()
@dkearns done.
I noticed that starlark is used in ftdetect, but there are no ftplugin files for this filetype. Should there be shim which sources bzl's?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
Is this correct?
A quick google search suggests, that *.sky is used for a few different file types> https://file.org/extension/sky
And also I couldn't find some references to *.skylark files. So do you have any references?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
@chrisbra I know for sure that sky is used. I added skylark to mirror with star and starlark, though I've never seen the latter being used.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
Can you mention a reference for this please?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
For .sky? https://docs.bazel.build/versions/0.17.1/skylark/spec.html still refers to it in some examples (Ctrl-f a.sky)
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
okay thanks. Then let me just include the *.sky thing.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
https://github.com/search?q=path%3A*.skylark&type=code returns 2 files
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()