[vim/vim] Reuse the same grow buffer across quickfix entries (PR #11365)
Yegappan Lakshmanan
The grow buffer is allocated and freed for each quickfix entry. This is inefficient. Reuse the same grow buffer across all the entries.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/11365
Commit Summary
- 56e6648 Reuse the same grow buffer across quickfix entries
File Changes
(3 files)
- M src/alloc.c (10)
- M src/proto/quickfix.pro (1)
- M src/quickfix.c (116)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
@yegappan pushed 1 commit.
- a1f3d1b Fix tiny build failure
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Codecov Report
Merging #11365 (a1f3d1b) into master (ba43e76) will increase coverage by
0.60%.
The diff coverage is97.67%.
@@ Coverage Diff @@ ## master #11365 +/- ## ========================================== + Coverage 81.87% 82.47% +0.60% ========================================== Files 162 152 -10 Lines 189326 179334 -9992 Branches 43064 40713 -2351 ========================================== - Hits 155014 147910 -7104 + Misses 21769 19159 -2610 + Partials 12543 12265 -278
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | 82.75% <97.67%> (-0.01%) |
⬇️ |
| huge-gcc-none | ? |
|
| huge-gcc-testgui | 53.15% <97.61%> (-0.01%) |
⬇️ |
| huge-gcc-unittests | 0.29% <0.00%> (-0.01%) |
⬇️ |
| linux | 82.47% <97.67%> (-0.07%) |
⬇️ |
| mingw-x64-HUGE | ? |
|
| mingw-x86-HUGE | ? |
|
| windows | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/quickfix.c | 90.84% <97.61%> (-0.45%) |
⬇️ |
| src/alloc.c | 78.21% <100.00%> (-0.16%) |
⬇️ |
| src/regexp_bt.c | 78.48% <0.00%> (-7.48%) |
⬇️ |
| src/json.c | 77.84% <0.00%> (-5.47%) |
⬇️ |
| src/regexp_nfa.c | 85.15% <0.00%> (-4.72%) |
⬇️ |
| src/libvterm/src/parser.c | 55.18% <0.00%> (-4.15%) |
⬇️ |
| src/edit.c | 82.88% <0.00%> (-3.49%) |
⬇️ |
| src/gui.c | 69.72% <0.00%> (-3.16%) |
⬇️ |
| src/normal.c | 87.97% <0.00%> (-3.00%) |
⬇️ |
| src/libvterm/src/screen.c | 50.18% <0.00%> (-2.85%) |
⬇️ |
| ... and 123 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
> The grow buffer is allocated and freed for each quickfix entry. This
> is inefficient. Reuse the same grow buffer across all the entries.
Perhaps the buffer should be cleared once an operation is done, e.g.
when it uses more than 300 bytes of memory.
--
TIM: To the north there lies a cave, the cave of Caerbannog, wherein, carved
in mystic runes, upon the very living rock, the last words of Olfin
Bedwere of Rheged make plain the last resting place of the most Holy
Grail.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
> The grow buffer is allocated and freed for each quickfix entry. This
> is inefficient. Reuse the same grow buffer across all the entries.
Thanks, I'll include it.
Perhaps the buffer should be cleared once an operation is done, e.g.
when it uses more than 300 bytes of memory.
vim-dev ML
On Fri, Oct 14, 2022 at 5:08 AM Bram Moolenaar ***@***.***>
wrote:
>
> > The grow buffer is allocated and freed for each quickfix entry. This
> > is inefficient. Reuse the same grow buffer across all the entries.
>
>
> Perhaps the buffer should be cleared once an operation is done, e.g.
> when it uses more than 300 bytes of memory.
>
>
>
I have created PR #11379 to free the grow array buffer after use if it uses
more
than 2K bytes of memory.
- Yegappan
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.