[vim/vim] tests: Test_popup_opacity_vsplit() fails with large terminal (PR #19824)
Christian Brabandt
Problem: tests: Test_popup_opacity_vsplit() fails with large terminal
(after v9.2.0230)
Solution: Reduce terminal window size to 60, force termguicolors to make
the opacity visible
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19824
Commit Summary
- 9e3a1f9 tests: Test_popup_opacity_vsplit() fails with large terminal
File Changes
(3 files)
- M src/testdir/dumps/Test_popupwin_opacity_vsplit_1.dump (24)
- M src/testdir/dumps/Test_popupwin_opacity_vsplit_2.dump (24)
- M src/testdir/test_popupwin.vim (5)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra pushed 1 commit.
- 95ffcf6 fix failing test Test_visual_block_hl_with_autoselect()
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
zeertzjq left a comment (vim/vim#19824)I think changing the char_avail() in clear_showcmd() to something similar to #19801 will fix the flaky test:
diff --git a/src/normal.c b/src/normal.c index a9b01821d..6f2bcc710 100644 --- a/src/normal.c +++ b/src/normal.c @@ -1616,7 +1616,8 @@ clear_showcmd(void) if (!p_sc) return; - if (VIsual_active && !char_avail()) + if (VIsual_active + && stuff_empty() && typebuf.tb_len == 0 && !using_script()) { int cursor_bot = LT_POS(VIsual, curwin->w_cursor); long lines;
And perhaps make the TermWait() unnecessary.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19824)thanks, let me try this change
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra pushed 1 commit.
- 162f23d visual selection size not shown in showcmd during scripts
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.