[vim/vim] feat: add extrahl in complete function (PR #15314)

glepnir

unread,

Jul 21, 2024, 3:44:06 AM (yesterday) Jul 21

to vim/vim, Subscribed

LSP spec mentioned completion item deprecated field when a completion item mark as deprecate the item should has a special highlight strikethrough. helix also have this. currently implement is add an extra field extrahl for combine. in this PR it works like

9c54d3688781f2567407da1d08232d67.png (view on web)

Ref: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionItem

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/15314

Commit Summary

241c7f1 feat: add extrahl in complete function

File Changes

(3 files)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

glepnir

unread,

Jul 21, 2024, 3:45:31 AM (yesterday) Jul 21

to vim/vim, Subscribed

how we test strikethrough in Ci..

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

glepnir

unread,

Jul 21, 2024, 3:53:02 AM (yesterday) Jul 21

to vim/vim, Push

@glepnir pushed 1 commit.

7e79096 feat: add extrahl in complete function

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

glepnir

unread,

2:10 AM (6 hours ago) 2:10 AM

to vim/vim, Subscribed

@glepnir commented on this pull request.

In src/insexpand.c:

> @@ -114,6 +114,7 @@ struct compl_S
     int		cp_flags;	// CP_ values
     int		cp_number;	// sequence number
     int		cp_score;	// fuzzy match score
+    int		cp_extrahlattr;	// extra highlight group attr

extrahlattr a little long maybe need a better name here ?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward