[vim/vim] tests: make Test_cd_completion more robust on Windows (PR #19078)
MURAOKA Taro
Problem: tests: Test_cd_completion() may fail depending on the contents of the root directory of the current drive on Windows.
readdir() may return a directory that cannot "cd" to, causing this test to fail. An example of such a directory is "System Volume Information" which only admin can "cd" to.
Solution: When determining the directory to use for testing, use the directory that we actually "cd" to successfully.
In addition, directories with '$' in their names are also excluded, as they are considered environment variables during completion and do not work as expected. Example: "$RECYCLE.BIN"
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19078
Commit Summary
- a5acc83 tests: make Test_cd_completion more robust on Windows
File Changes
(1 file)
- M src/testdir/test_cd.vim (36)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
MURAOKA Taro
koron left a comment (vim/vim#19078)The current GitHub Actions CI succeeds because winpty is deployed to D:\winpty, which is used in this test.
(from: https://github.com/koron/vim/actions/runs/20678705394/job/59369849570#step:11:72)
successful_drive.png (view on web)
If winpty is not deployed, the test will fail.
(from: https://github.com/koron/vim-kaoriya/actions/runs/20678636028/job/59369699247#step:3:16)
failing_drive.png (view on web)
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19078)Ah, that makes sense. Thanks for investigating
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.