[vim/vim] runtime(syntax-tests): Apply "word" rather than "prefix" when filtering filetypes (PR #21351)
Aliaksei Budavei
Whenever two or more filetype names share a common prefix,
e.g. java and javascript, passing the shortest name
argument to Make, e.g. make java test, will trigger the
running of all prefix matching test suites. To fix this
blunder and to only have requested test suites run, always
append the leftmost conventional delimiters [._], e.g.
java[.]java, java[_]numbers.java, to each filetype name
when automatically assembling a regexp pattern for the
filename filter. Furthermore, promote the Vim9 (pseudo-)
filetype, e.g. make vim9 test, make vim vim9 test, etc.
As before, VIM_SYNTAX_TEST_FILTER is still within reach for
arbitrary test case grouping.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/21351
Commit Summary
- 46a4d7e runtime(syntax-tests): Apply "word" rather than "prefix" when filtering filetypes
File Changes
(3 files)
- M runtime/syntax/Makefile (1)
- M runtime/syntax/testdir/runtest.vim (7)
- M runtime/syntax/testdir/tools/maketestdeps (3)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Aliaksei Budavei
zzzyxwvut left a comment (vim/vim#21351)Heads up, @dkearns and @e-kwsm.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
dkearns
dkearns left a comment (vim/vim#21351)"blunder" seems like a rather harsh assessment. :)
Thanks for special casing my abusive vim9 usage. I am, however, more than happy to rename those tests to something like vim_9_* if you prefer.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#21351)thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.