[vim/vim] Add support for Unix-domain sockets (PR #10062)

LemonBoy

unread,

Apr 2, 2022, 10:33:55 AM4/2/22

to vim/vim, Subscribed

As written on the tin this PR allows Vim channels to connect to Unix-domain sockets, much nicer than TCP for local tasks and possibly faster (?).

Open questions:

The documentation could be better (suggestions welcome)
The port argument is omitted in ch_info, is that better than returning a meaningless value (empty string or zero)?
Should ch_info return any info about the kind of socket it's connected to (ipv4, ipv6, unix)?
The whole thing should work on recent Windows 10 versions, testing is needed though.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/10062

Commit Summary

9e7cd69 Improve logic to find python executable
375d8f5 Support connecting to Unix-domain sockets
cbb3ac7 Fix compilation issues

File Changes

(7 files)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

LemonBoy

unread,

Apr 2, 2022, 11:56:52 AM4/2/22

to vim/vim, Push

@LemonBoy pushed 1 commit.

18b5050 Remove leftover test files

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

LemonBoy

unread,

Apr 2, 2022, 12:21:03 PM4/2/22

to vim/vim, Subscribed

No idea what's wrong with the CI, the python script and the test suite both work fine on my system.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Apr 2, 2022, 3:18:34 PM4/2/22

to vim/vim, Subscribed

Perhaps ch_info() can return port zero to indicate a unix-domain socket?
The hostname is already used for the path, that combination would make sense.
Otherwise the info should have "path" and omit hostname and port.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

LemonBoy

unread,

Apr 2, 2022, 5:25:51 PM4/2/22

to vim/vim, Push

@LemonBoy pushed 1 commit.

3d18369 Changes to ch_info()

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Apr 3, 2022, 11:01:16 AM4/3/22

to vim/vim, Subscribed

Tests are still failing.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

LemonBoy

unread,

Apr 3, 2022, 3:46:37 PM4/3/22

to vim/vim, Push

@LemonBoy pushed 1 commit.

2774ff3 Make the script compatible with Python 2

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

LemonBoy

unread,

Apr 3, 2022, 4:21:39 PM4/3/22

to vim/vim, Push

@LemonBoy pushed 1 commit.

afb8efe Unix sockets are not supported by Python on Windows

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

LemonBoy

unread,

Apr 3, 2022, 4:30:03 PM4/3/22

to vim/vim, Subscribed

The tests are ok now, the CI failure is unrelated as master is also red right now.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Apr 4, 2022, 10:47:50 AM4/4/22

to vim/vim, Subscribed

Closed #10062 via cc766a8.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward