[vim/vim] Fix Perl interface to load PL_current_context from library (PR #12996)

Yee Cheng Chin

unread,

Sep 1, 2023, 12:56:07 AM9/1/23

to vim/vim, Subscribed

In #12914, in order to fix an issue with Perl 5.36 dynamic builds, (that version introduced a thread-local PL_current_context), the file added the variable manually so we can satisfy the linker. However, the variable is a different one from the one in the library, so there could be unpredictable behavior. Instead, just use dlsym to load the context from the library. The fact that it's thread-local doesn't matter too much to us because Vim's interface is single-threaded so it will work properly.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/12996

Commit Summary

837ca3a Fix Perl interface to load PL_current_context from library

File Changes

(1 file)

M src/if_perl.xs (13)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Yee Cheng Chin

unread,

Sep 1, 2023, 12:56:44 AM9/1/23

to vim/vim, Subscribed

This is to address this comment: 55460da#r125864409

From testing they both build, but this should be the more correct way to do it.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

codecov[bot]

unread,

Sep 1, 2023, 1:15:53 AM9/1/23

to vim/vim, Subscribed

Codecov Report

Merging #12996 (837ca3a) into master (816fbcc) will decrease coverage by 5.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12996      +/-   ##
==========================================
- Coverage   82.07%   76.62%   -5.45%     
==========================================
  Files         160      150      -10     
  Lines      194776   152120   -42656     
  Branches    43713    39202    -4511     
==========================================
- Hits       159853   116557   -43296     
- Misses      22056    23536    +1480     
+ Partials    12867    12027     -840

Flag	Coverage Δ
huge-clang-Array	`?`
linux	`?`
mingw-x64-HUGE	`76.62% <ø> (-0.01%)`	⬇️
mingw-x86-HUGE	`?`
windows	`76.62% <ø> (-1.60%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 156 files with indirect coverage changes

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Sep 1, 2023, 12:48:38 PM9/1/23

to vim/vim, Subscribed

Closed #12996 via 7a9d1aa.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward