[vim/vim] Can we make the hard-coded value a bit bigger ? (#8855)

Andres Monge

unread,

Sep 9, 2021, 11:01:14 AM9/9/21

to vim/vim, Subscribed

https://github.com/vim/vim/blob/bc67e5a0a494f5fc48e872d747371e31a782d171/src/search.c#L40

Maybe move this from 99 to 9999 ?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Christian Brabandt

unread,

Sep 9, 2021, 11:21:49 AM9/9/21

to vim/vim, Subscribed

do you actually run into that limit? If so, when and how? I had that problem just recently with a huge logfile, but before that, I have never run into it and I have used that feature right from the beginning. So I am wondering.

Bram Moolenaar

unread,

Sep 9, 2021, 11:44:18 AM9/9/21

to vim/vim, Subscribed

If you have more than 99 matches, does the number matter? The larger the number, the slower it gets.

Gary Johnson

unread,

Sep 9, 2021, 12:03:23 PM9/9/21

to reply+ACY5DGEDRDROQ6WQRY...@reply.github.com, vim...@googlegroups.com

On 2021-09-09, Bram Moolenaar wrote:
> If you have more than 99 matches, does the number matter? The larger the
> number, the slower it gets.

I run into this maybe once a week. If the number is >99, it would
be nice to know how big it is and where the cursor is currently in
the list--all the reasons it's nice to have those stats in the first
place.

I know that larger is slower and I've assumed that you've found 99
to be a good trade-off. I can live with 99, but I've run into that
limit often enough that it would be nice if it could be bigger or
changeable. Maybe I should bump it up and see how big it gets and
how slow it gets.

Regards,
Gary

vim-dev ML

unread,

Sep 9, 2021, 12:03:41 PM9/9/21

to vim/vim, vim-dev ML, Your activity

Andres Monge

unread,

Jan 5, 2022, 4:48:41 AM1/5/22

to vim/vim, vim-dev ML, Comment

I can't remember now where I found the limit frustrating. But as said, it happened once only, so I would agree with you all that it's not necessary if performance will be affected.

—

Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you commented.

Andres Monge

unread,

Jan 5, 2022, 4:48:41 AM1/5/22

to vim/vim, vim-dev ML, Comment

Closed #8855.

—

Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you commented.

Reply all

Reply to author

Forward