[vim/vim] Matched text isn't highlighted in cmdline pum (PR #15029)

zeertzjq

unread,

Jun 16, 2024, 11:08:42 PM (10 days ago) Jun 16

to vim/vim, Subscribed

Problem: Matched text isn't highlighted in cmdline pum.
Solution: Use cmdline completion pattern in cmdline mode.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/15029

Commit Summary

a41890c Matched text isn't highlighted in cmdline pum

File Changes

(10 files)

M src/cmdexpand.c (22)
M src/popupmenu.c (17)
M src/proto/cmdexpand.pro (2)
A src/testdir/dumps/Test_wildmenu_pum_hl_match_1.dump (10)
A src/testdir/dumps/Test_wildmenu_pum_hl_match_2.dump (10)
A src/testdir/dumps/Test_wildmenu_pum_hl_match_3.dump (10)
A src/testdir/dumps/Test_wildmenu_pum_hl_match_4.dump (10)
A src/testdir/dumps/Test_wildmenu_pum_hl_match_5.dump (10)
A src/testdir/dumps/Test_wildmenu_pum_hl_match_6.dump (10)
M src/testdir/test_cmdline.vim (31)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jun 17, 2024, 2:51:45 AM (9 days ago) Jun 17

to vim/vim, Push

@zeertzjq pushed 1 commit.

e7e57b6 Matched text isn't highlighted in cmdline pum

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jun 17, 2024, 2:56:01 AM (9 days ago) Jun 17

to vim/vim, Subscribed

For non-fuzzy matching this isn't always accurate, as every kind of Cmdline completion has a different kind of non-fuzzy matching procedure. This PR only uses prefix matching like what is used for Insert mode completion.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Shane-XB-Qian

unread,

Jun 17, 2024, 3:28:34 AM (9 days ago) Jun 17

to vim/vim, Subscribed

perhaps better be refer this ticket with #15021

and this fuzzy of cli I recalled was impl by @yegappan so perhaps he can input something?

or I am not sure cli pum should be something like insert-compl? vs fuzzy of cli was good but fuzzy of insert-compl so far I can't completely feel that's a good idea.

--
shane.xb.qian

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Shane-XB-Qian

unread,

Jun 17, 2024, 3:48:55 AM (9 days ago) Jun 17

to vim/vim, Subscribed

um.. the cli compl seems was from @ychin
let's see if there some input, or just your said way.

--
shane.xb.qian

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jun 17, 2024, 12:17:37 PM (9 days ago) Jun 17

to vim/vim, Subscribed

Thanks for that!

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jun 17, 2024, 12:27:17 PM (9 days ago) Jun 17

to vim/vim, Subscribed

Closed #15029 via d8c9340.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward