Patch 8.1.2222

14 views
Skip to first unread message

Bram Moolenaar

unread,
Oct 26, 2019, 2:48:11 PM10/26/19
to vim...@googlegroups.com

Patch 8.1.2222
Problem: Accessing invalid memory. (Dominique Pelle)
Solution: Reset highlight_match every time. (closes #5125)
Files: src/ex_getln.c


*** ../vim-8.1.2221/src/ex_getln.c 2019-10-18 20:53:30.697741631 +0200
--- src/ex_getln.c 2019-10-26 20:39:13.367570835 +0200
***************
*** 525,530 ****
--- 525,531 ----
curwin->w_redr_status = TRUE;

update_screen(SOME_VALID);
+ highlight_match = FALSE;
restore_last_search_pattern();

// Leave it at the end to make CTRL-R CTRL-W work. But not when beyond the
***************
*** 642,647 ****
--- 643,649 ----
highlight_match = TRUE;
save_viewstate(&is_state->old_viewstate);
update_screen(NOT_VALID);
+ highlight_match = FALSE;
redrawcmdline();
curwin->w_cursor = is_state->match_end;
}
*** ../vim-8.1.2221/src/version.c 2019-10-26 17:33:00.033437181 +0200
--- src/version.c 2019-10-26 20:43:18.098503801 +0200
***************
*** 743,744 ****
--- 743,746 ----
{ /* Add new patch number below this line */
+ /**/
+ 2222,
/**/

--
EXPERIENCE - experience is a wonderful thing. It enables you to
recognise a mistake when you make it again.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Dominique Pellé

unread,
Oct 26, 2019, 6:03:38 PM10/26/19
to vim_dev
Bram Moolenaar <Br...@moolenaar.net> wrote:

> Patch 8.1.2222
> Problem: Accessing invalid memory. (Dominique Pelle)
> Solution: Reset highlight_match every time. (closes #5125)
> Files: src/ex_getln.c

Thanks! So far I have not been able to reproduce the
crash anymore after patch 8.1.2222. The crash was
happening rarely, so I can't be 100% sure it's fixed,
but it looks like this patch fixed it.

Regards
Dominique
Reply all
Reply to author
Forward
0 new messages