[vim/vim] avoid overwriting right-top corner when drawing top border (PR #19299)
mattn
When drawing the top border of a popup window, screen_fill() was called with wincol + total_width as the end column, which caused it to overwrite the right-top corner character (border_char[5]) that is placed at wincol + total_width - 1. The overwritten character would display with attr=0 (default background), appearing as black.
image.png (view on web)So, change the end column from wincol + total_width to wincol + total_width - 1, so that screen_fill() does not overwrite
the right-top corner character. This fix applies to all popup windows, including those using multibyte
characters for borders.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19299
Commit Summary
- d32037b avoid overwriting right-top corner when drawing top border
File Changes
(1 file)
- M src/popupwin.c (2)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 1 commit.
- 138ffdd update dump files
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19299)Hm, if you inspect the dump files, this looks slightly wrong:
image.png (view on web)
image.png (view on web)
Now it seems the border is drawn 1 char too short?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 2 commits.
You are receiving this because you are subscribed to this thread.
mattn
mattn left a comment (vim/vim#19299)I updated patch. I want to test with same dump file. Which dump file do you use?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
