[vim/vim] Fix :bd/bun/bw attempting switch to closing buffer (PR #19107)

Sean Dewar

unread,

Jan 6, 2026, 9:50:53 AM (3 days ago) Jan 6

to vim/vim, Subscribed

Problem: :bdelete/bunload/bwipeout may attempt to switch to a closing buffer, which fails. (after 9.1.2058)

Solution: don't consider switching to closing buffers.

Ugh. Silver lining is that before 9.1.2058 it could've instead been a UAF. 😁

Ref: neovim/neovim#37271 (comment)
TODO: needs tests

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/19107

Commit Summary

1360f8e Fix :bd/bun/bw attempting switch to closing buffer

File Changes

(1 file)

M src/buffer.c (17)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Sean Dewar

unread,

Jan 6, 2026, 11:49:31 AM (3 days ago) Jan 6

to vim/vim, Push

@seandewar pushed 1 commit.

d811d14 Fix :bd/bun/bw attempting switch to closing buffer

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

Sean Dewar

unread,

Jan 6, 2026, 12:42:27 PM (3 days ago) Jan 6

to vim/vim, Push

@seandewar pushed 1 commit.

27c805f Fix :bd/bun/bw attempting switch to closing buffer

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jan 7, 2026, 9:29:36 PM (2 days ago) Jan 7

to vim/vim, Subscribed

@zeertzjq commented on this pull request.

In src/testdir/test_buffer.vim:

> +          \| call assert_equal('bar', bufname())
+          \| bunload
+          \| call assert_equal('floob', bufname())
+  augroup END
+  buffer bazinga
+  buffer baz
+  buffer floob
+  buffer foo
+  buffer bar
+  noautocmd bdelete foo
+  clearjumps
+  bdelete bazinga
+  call assert_equal(6, s:fired)
+
+  unlet! s:fired
+  autocmd! SkipClosing

⬇️ Suggested change

-  autocmd! SkipClosing
+  autocmd! SkipClosing
+  augroup! SkipClosing

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jan 7, 2026, 9:33:36 PM (2 days ago) Jan 7

to vim/vim, Subscribed

@zeertzjq commented on this pull request.

In src/testdir/test_buffer.vim:

> +          \| call assert_equal('bar', bufname())
+          \| bunload
+          \| call assert_equal('floob', bufname())
+  augroup END
+  buffer bazinga
+  buffer baz
+  buffer floob
+  buffer foo
+  buffer bar
+  noautocmd bdelete foo
+  clearjumps
+  bdelete bazinga
+  call assert_equal(6, s:fired)
+
+  unlet! s:fired
+  autocmd! SkipClosing

Actually this isn't really needed. There are many other tests that don't delete augroups.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jan 8, 2026, 4:27:23 PM (yesterday) Jan 8

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#19107)

thanks

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jan 8, 2026, 4:31:37 PM (yesterday) Jan 8

to vim/vim, Subscribed

Closed #19107 via 63d53de.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward