typo in commit message for v8.1.1684 and v8.1.1685

12 views
Skip to first unread message

Tony Mechelynck

unread,
Jul 14, 2019, 2:41:09 AM7/14/19
to Bram Moolenaar, vim_dev
"profiling.c" and "profiling.pro" should be "profiler.c" and
"profiler.pro" respectively. If (like me) you're compiling in a shadow
directory, you must link profiler.c, not profiling.c, from the
shadowdir to its parent, i.e. (the shadow directory being current, and
assuming a Unix-like OS)

ln -sv ../profiler.c

profiler.pro will be linked automatically by virtue of the link proto
-> ../proto in the src directory.


Best regards,
Tony.

Bram Moolenaar

unread,
Jul 14, 2019, 8:56:06 AM7/14/19
to vim...@googlegroups.com, Tony Mechelynck

Tony wrote:

> "profiling.c" and "profiling.pro" should be "profiler.c" and
> "profiler.pro" respectively.

I'll correct that in the text.

> If (like me) you're compiling in a shadow
> directory, you must link profiler.c, not profiling.c, from the
> shadowdir to its parent, i.e. (the shadow directory being current, and
> assuming a Unix-like OS)
>
> ln -sv ../profiler.c

"make shadow" takes care of that, right? Or does that not work if the
directory already exists? I suppose that never worked then.

> profiler.pro will be linked automatically by virtue of the link proto
> -> ../proto in the src directory.

--
Save the plankton - eat a whale.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Tony Mechelynck

unread,
Jul 14, 2019, 12:54:23 PM7/14/19
to Bram Moolenaar, vim_dev
On Sun, Jul 14, 2019 at 2:56 PM Bram Moolenaar <Br...@moolenaar.net> wrote:
>
>
> Tony wrote:
>
> > "profiling.c" and "profiling.pro" should be "profiler.c" and
> > "profiler.pro" respectively.
>
> I'll correct that in the text.
>
> > If (like me) you're compiling in a shadow
> > directory, you must link profiler.c, not profiling.c, from the
> > shadowdir to its parent, i.e. (the shadow directory being current, and
> > assuming a Unix-like OS)
> >
> > ln -sv ../profiler.c
>
> "make shadow" takes care of that, right? Or does that not work if the
> directory already exists? I suppose that never worked then.

"make shadow" takes care of linking src/proto to proto one level
higher, so that new *.pro files created afterward are automatically
taken care of.

"make shadow" also links $SHADOWDIR/*.c one by one to src/*.c but when
doing incremental compiles in an _existing_ shadowdir, _new_ *.c and
*.h sources which did not exist when the shadowdir was created must be
linked manually. Some time ago I proposed to add a rule for that in
the Makefile, which would create the link if a missing file existed in
the directory one level higher, but that post seems to have fallen off
the radar... let me find it back... ah, here:
https://groups.google.com/d/msg/vim_dev/lH4KGoz3Ppo/PcgWEmJWBQAJ

>
> > profiler.pro will be linked automatically by virtue of the link proto
> > -> ../proto in the src directory.
>
> --
> Save the plankton - eat a whale.

Best regards,
Tony.
Reply all
Reply to author
Forward
0 new messages