[vim/vim] Add runtime files and filetype detection for jj (PR #14733)
Gregory Anders
jj (Jujutsu) is a Git-compatible version control system.
Like git, jj allows the user to write a description of each change in a buffer. These are opened in the editor with a temporary file with a .jjdescription extension. Example:
Add runtime files and filetype detection for jj
JJ: This commit contains the following changes:
JJ: M runtime/filetype.vim
JJ: A runtime/ftplugin/jj.vim
JJ: A runtime/syntax/jj.vim
JJ: Lines starting with "JJ: " (like this one) will be removed.
The format of the file is similar to a Git commit file. There is some plain text at the top of the file describing the change and some comments showing which files changed. The comment character is JJ: (indicated by the text in the buffer).
The included syntax plugin highlights comments with the Comment highlight group, and highlights each of the individual changed files using the builtin Added, Changed, and Removed highlight groups.
The include filetype plugin is copied almost verbatim from the gitcommit filetype plugin, though I dropped the Git commands and adapted for the updated comment strings.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/14733
Commit Summary
- d03a694 Add runtime files and filetype detection for jj
File Changes
(3 files)
- M runtime/filetype.vim (3)
- A runtime/ftplugin/jj.vim (19)
- A runtime/syntax/jj.vim (20)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Thanks, can you please add your email or github handle at the maintainer line? And perhaps update https://github.com/vim/vim/blob/master/.github/CODEOWNERS ?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Clason
Just a small comment: Users in CODEOWNERS actually have to be members of the org; otherwise this will not work properly and Github will complain that "This file has errors".
Of course, you can still use that file for your own tracking purposes, but I wonder if a different name and format (MAINTAINERS.{md,txt}) wouldn't be more useful then (and shut Github up)?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
Can you please add a filetype detection test?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
Just a small comment: Users in
CODEOWNERSactually have to be members of the org; otherwise this will not work properly and Github will complain that "This file has errors".Of course, you can still use that file for your own tracking purposes, but I wonder if a different name and format (
MAINTAINERS.{md,txt}) wouldn't be more useful then (and shut Github up)?
This used to work for all users and there was some hope that the feature might be restored. That hope is fading...
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Gregory Anders
@gpanders pushed 2 commits.
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Gregory Anders
@gpanders pushed 1 commit.
- 3d3e695 add filetype detection test
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Gregory Anders
Can you please add a filetype detection test?
Done, thanks for the reminder.
Thanks, can you please add your email or github handle at the maintainer line
Done as well. I didn't update CODEOWNERS tho, per @clason's comment it sounds like that may not work as intended? But if you prefer I can update it regardless.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Yeah, I noticed that warning. It's not particular useful that one cannot add non-org people there. I have just renamed it to MAINTAINERs (in 3ac83c7) Not sure if it is actually useful (or it's just redundant).
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
now you can add it to the MAINTAINERS file 😬
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Gregory Anders
Gregory Anders
now you can add it to the MAINTAINERS file 😬
Done!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
thanks!
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.