[vim/vim] Fix left window 'winhighlight' being used when drawing middle statusline separator (PR #19980)
Foxe Chen
This was caused by #19951:
https://github.com/user-attachments/assets/2aad191f-5e82-4c85-8a76-89954967abb0
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19980
Commit Summary
- c770362 fix left window 'winhighlight' being used when drawing right window
File Changes
(4 files)
- M src/highlight.c (13)
- A src/testdir/dumps/Test_VertSplitNC_whl1.dump (12)
- A src/testdir/dumps/Test_VertSplitNC_whl2.dump (12)
- M src/testdir/test_highlight.vim (24)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
h_east
@h-east commented on this pull request.
In src/highlight.c:
> @@ -5804,9 +5805,10 @@ set_highlight_attr(hl_override_T *arr, int len, bool update_ids)
bool
push_highlight_overrides(hl_override_T *arr, int len)
{
- // Don't want to do anything if "arr" is NULL or if "arr" is already the
- // current override.
- if (arr == NULL || (overrides != NULL && overrides->arr == arr))
+ // Don't want to do anything if "arr" is already the current override. If
+ // "arr" is NULL, then still push an override, but "->arr" will just be
+ // NULL so any previous overrides are cleared.
+ if (arr != NULL && overrides != NULL && overrides->arr == arr)
I don't think arr != NULL && is necessary.
While it's not incorrect since push/pop are supported, it will result in unnecessary alloc/free operations.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Foxe Chen
@64-bitman pushed 1 commit.
- 703682d fix left window 'winhighlight' being used when drawing right window
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19980)thanks both
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.