[vim/vim] 'linebreak' may lead to wrong Visual block highlighting (PR #19900)
zeertzjq
Problem: 'linebreak' may lead to wrong Visual block highlighting when
end char occupies multiple cells (after 7.4.467).
Solution: Exclude 'linebreak' from the ending column instead of setting
'virtualedit' temporarily.
fixes: #19898
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19900
Commit Summary
- 70352cd 'linebreak' may lead to wrong Visual block highlighting
File Changes
(29 files)
- M src/change.c (2)
- M src/charset.c (59)
- M src/cindent.c (18)
- M src/drawline.c (20)
- M src/drawscreen.c (15)
- M src/edit.c (6)
- M src/evalfunc.c (6)
- M src/ex_cmds.c (6)
- M src/gui_xim.c (2)
- M src/indent.c (2)
- M src/misc1.c (4)
- M src/misc2.c (12)
- M src/mouse.c (9)
- M src/move.c (8)
- M src/normal.c (15)
- M src/ops.c (25)
- M src/popupwin.c (4)
- M src/proto/charset.pro (8)
- M src/regexp.c (4)
- M src/regexp_bt.c (2)
- M src/regexp_nfa.c (2)
- M src/register.c (8)
- M src/search.c (2)
- A src/testdir/dumps/Test_visual_block_hl_with_linebreak_1.dump (6)
- A src/testdir/dumps/Test_visual_block_hl_with_linebreak_2.dump (6)
- A src/testdir/dumps/Test_visual_block_hl_with_linebreak_3.dump (6)
- A src/testdir/dumps/Test_visual_block_hl_with_linebreak_4.dump (6)
- M src/testdir/test_listlbr_utf8.vim (67)
- M src/vim.h (3)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
zeertzjq left a comment (vim/vim#19900)Note: the TODOs in the code aren't related to the issue and are left for future PRs.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
zeertzjq
@zeertzjq pushed 1 commit.
- 5a8ac3f 'linebreak' may lead to wrong Visual block highlighting
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19900)thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.