[vim/vim] Fix #18563: Remove complete_match() and 'isexpand' (PR #18790)
girish
Fixes #18563
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/18790
Commit Summary
- e0405e5 Remove complete_match() and 'isexpand'
File Changes
(19 files)
- M runtime/doc/builtin.txt (46)
- M runtime/doc/intro.txt (1)
- M runtime/doc/options.txt (17)
- M runtime/doc/tags (3)
- M runtime/doc/usr_41.txt (2)
- M runtime/optwin.vim (1)
- M runtime/syntax/vim.vim (6)
- M src/buffer.c (1)
- M src/evalfunc.c (2)
- M src/insexpand.c (128)
- M src/option.c (7)
- M src/option.h (1)
- M src/optiondefs.h (5)
- M src/optionstr.c (43)
- M src/proto/insexpand.pro (1)
- M src/proto/optionstr.pro (1)
- M src/structs.h (1)
- M src/testdir/test_ins_complete.vim (93)
- M src/testdir/util/gen_opt_test.vim (1)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
girish
@girishji pushed 1 commit.
- d859f21 Remove unused code
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
girish
girishji left a comment (vim/vim#18790)I removed this line from :h credits:
glepnir completion feature
This individual is not the author of the completion feature. Their changes introduced regressions in both the completion and fuzzy features, and they were in the process of merging additional problematic code (details available on request). If you disagree and think credit is warranted, then include only specific, verifiable contributions and consider them in light of the numerous issues I had to resolve. I’m not interested in further debate on this.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
techntools
techntools left a comment (vim/vim#18790)Why not add both of you as authors ?
@glepnir contributed first working fuzzy insert mode completion
We all appreciate the fixes you made. Not only that your search mode completion is awesome
But he indeed invested time and efforts and provided a foundation for others to make it better
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
glepnir
@glepnir requested changes on this pull request.
> @@ -275,7 +275,6 @@ Vim would never have become what it is now, without the help of these people! improvements Doug Kearns Runtime file maintainer Foxe Chen Wayland support, new features - glepnir completion feature
You doesn’t know how to respect other people right ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra commented on this pull request.
> @@ -275,7 +275,6 @@ Vim would never have become what it is now, without the help of these people! improvements Doug Kearns Runtime file maintainer Foxe Chen Wayland support, new features - glepnir completion feature
Sorry, I think removing you from the credit section is not warranted, so I'll just update that line to make it more accurate.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
glepnir
@glepnir commented on this pull request.
> @@ -275,7 +275,6 @@ Vim would never have become what it is now, without the help of these people! improvements Doug Kearns Runtime file maintainer Foxe Chen Wayland support, new features - glepnir completion feature
This is the last time I will speak with @girishji .
I have always avoided leaving any comments on issues or PRs involving you. The reason is simple: I believe you do not understand how to respect others. I also do not want to cause any conflict or trouble for chrisbra. This is an open-source project, and any PR will naturally have different opinions coming from different perspectives. If the end result is positive, then there is nothing wrong with that, and it will be accepted.
Also, as a member of the Vim organization, I am likewise fixing bugs within my ability, not only in the completion module. You can simply filter by author in the PR list. If you are so bothered by that note, @chrisbra can change it to “some bug fixes”—I have no objection.
Please stop your impolite behavior. It only makes your reputation here worse.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
glepnir
@glepnir commented on this pull request.
> @@ -275,7 +275,6 @@ Vim would never have become what it is now, without the help of these people! improvements Doug Kearns Runtime file maintainer Foxe Chen Wayland support, new features - glepnir completion feature
todo list should also revert
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
girish
girishji left a comment (vim/vim#18790)Re @glepnir
Each time I raise concerns about technical or ethical issues—and the resulting damage—they are met with personal attacks rather than engagement with the substance.
Example 1: #17387
You broke complete_info() and manipulated the tests to mask the failure.
I pointed this out here: #17387 (comment)
Your kind response here: #17387 (comment)
Screenshot.2025-11-28.at.11.51.19.AM.png (view on web)Example 2:
You attempted to merge dubious code: #17459
I pointed out the flaws here: #17459 (comment)
Screenshot.2025-11-28.at.11.53.37.AM.png (view on web)
Your response here: #17459 (comment)
Screenshot.2025-11-28.at.11.52.50.AM.png (view on web)
For context, I do not use the fuzzy completion feature. My involvement (starting with this: #17430) began only because the 'fuzzy' changes started interfering with the core completion mechanism—which is what I focus on.
Example 3:
You viciously tried to stop improvements to insert mode completion by opening a manufactured issue: #17347
You even pointed out that I was the only person using feature: #17347 (comment)
Screenshot.2025-11-28.at.11.54.26.AM.png (view on web)
It’s worth reiterating: the feature in question is foundational to Vim’s autocompletion system and external source support.
Example 4:
Here is an example of problematic code you were trying to add, that I intervened to stop. Of course you edited (and removed) your own comments (sad) and now anyone reading the thread will not get the full story of malfeasance.
Screenshot.2025-11-28.at.12.59.04.PM.png (view on web)
In addition, your poor design of fuzzy feature for insert mode broke the existing fuzzy matching for command completion (#17531 (comment)), and your subsequent attempts to 'fix' the algorithm made it worse, which prompted me (#17531 (comment), #17531 (comment)) to replace the algorithm itself (#17900).
I am sure you have put in a lot of work for this project. I am pretty sure I can find examples where you've added value around the margins (and I am thankful), but you are incapable of designing and implementing a major feature. Effort itself is of no value when results are poor.
Final NOTE: Listing you as an author of 'completion feature' is not appropriate. I assume this is just a honest mistake by @chrisbra.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.