Add new filetype detection and syntax file for Algol 68.
https://github.com/vim/vim/pull/19818
(4 files)
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
Thanks Doug, I was actually also going to create a PR for this, so thanks for taking care :)
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
@chrisbra commented on this pull request.
Thanks.
What is the issue with the many commented out lines in the syntax script? Can you please revert the changes to src/Makefile and runtime/syntax/sh.vim ?
Can you please also update the MAINTAINERS file?
In runtime/syntax/algol68.vim:
> +syn keyword algol68Operator SORT ELEMS
+syn keyword algol68Repeat FOR FROM BY UPTO DOWNTO TO WHILE DO UNTIL OD
+syn keyword algol68Statement PAR BEGIN END EXIT
+syn keyword algol68Struct STRUCT
+syn keyword algol68PreProc VECTOR
+syn keyword algol68Type FLEX HEAP LOC LONG REF SHORT
+syn keyword algol68Type VOID BOOL INT REAL COMPL CHAR STRING COMPLEX
+syn keyword algol68Type BITS BYTES FILE CHANNEL PIPE SEMA SOUND
+syn keyword algol68Type FORMAT STRUCT UNION
+
+ " 20011222az: Added new items.
+syn keyword algol68Todo contained TODO FIXME XXX DEBUG NOTE
+
+ " 20010723az: When wanted, highlight the trailing whitespace -- this is
+ " based on c_space_errors; to enable, use "algol68_space_errors".
+if exists("algol68_space_errors")
those settings should be documented
> @@ -831,7 +831,7 @@ endif
" Arithmetic Parenthesized Expressions: {{{1
"syn region shParen matchgroup=shArithRegion start='[^$]\zs(\%(\ze[^(]\|$\)' end=')' contains=@shArithParenList
-syn region shParen matchgroup=shArithRegion start='\$\@!(\%(\ze[^(]\|$\)' end=')' contains=@shArithParenList
+" syn region shParen matchgroup=shArithRegion start='\$\@!(\%(\ze[^(]\|$\)' end=')' contains=@shArithParenList
that probably does not belong here
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.![]()
@dkearns pushed 1 commit.
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
@dkearns pushed 1 commit.
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
@dkearns pushed 1 commit.
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
@chrisbra, it's too early to be reviewing. As I mentioned in the mail thread it'll take a few days to finalise, I was just trying to put it in motion during the last minutes of the day.
Thanks. What is the issue with the many commented out lines in the syntax script?
These are in the original patch and appear to exclude the non-ASCII operators. I don't think there's any reason these can't eventually be supported. These commented-out lines are also apparent in version 0.2 from fifteen years ago.
There's also what looks like some experimentation with priorities of the operator patterns, tests would be useful to clean this up.
Can you please also update the MAINTAINERS file?
I doubt Janis, from comments in the mail thread, has a GitHub handle so I've just used mine for now.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.![]()
@chrisbra, it's too early to be reviewing.
Ah okay, I'll hold off then, thanks for taking care
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.![]()
@dkearns pushed 1 commit.
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.![]()
@dkearns pushed 1 commit.
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.![]()