[vim/vim] runtime(algol68): Add new syntax file and filetype detection (PR #19818)

7 views
Skip to first unread message

dkearns

unread,
Mar 25, 2026, 7:46:14 AM (23 hours ago) Mar 25
to vim/vim, Subscribed

Add new filetype detection and syntax file for Algol 68.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/19818

Commit Summary

  • 4131534 runtime(algol68): Add new syntax file and filetype detection

File Changes

(4 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19818@github.com>

Christian Brabandt

unread,
Mar 25, 2026, 8:42:46 AM (22 hours ago) Mar 25
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#19818)

Thanks Doug, I was actually also going to create a PR for this, so thanks for taking care :)


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19818/c4126294069@github.com>

Christian Brabandt

unread,
Mar 25, 2026, 3:34:29 PM (15 hours ago) Mar 25
to vim/vim, Subscribed

@chrisbra commented on this pull request.

Thanks.
What is the issue with the many commented out lines in the syntax script? Can you please revert the changes to src/Makefile and runtime/syntax/sh.vim ?
Can you please also update the MAINTAINERS file?


In runtime/syntax/algol68.vim:

> +syn keyword algol68Operator	SORT ELEMS
+syn keyword algol68Repeat	FOR FROM BY UPTO DOWNTO TO WHILE DO UNTIL OD
+syn keyword algol68Statement	PAR BEGIN END EXIT
+syn keyword algol68Struct	STRUCT
+syn keyword algol68PreProc	VECTOR
+syn keyword algol68Type		FLEX HEAP LOC LONG REF SHORT
+syn keyword algol68Type		VOID BOOL INT REAL COMPL CHAR STRING COMPLEX
+syn keyword algol68Type		BITS BYTES FILE CHANNEL PIPE SEMA SOUND
+syn keyword algol68Type		FORMAT STRUCT UNION 
+
+    " 20011222az: Added new items.
+syn keyword algol68Todo contained	TODO FIXME XXX DEBUG NOTE
+
+    " 20010723az: When wanted, highlight the trailing whitespace -- this is
+    " based on c_space_errors; to enable, use "algol68_space_errors".
+if exists("algol68_space_errors")

those settings should be documented


In runtime/syntax/sh.vim:

> @@ -831,7 +831,7 @@ endif
 
 " Arithmetic Parenthesized Expressions: {{{1
 "syn region shParen matchgroup=shArithRegion start='[^$]\zs(\%(\ze[^(]\|$\)' end=')' contains=@shArithParenList
-syn region shParen matchgroup=shArithRegion start='\$\@!(\%(\ze[^(]\|$\)' end=')' contains=@shArithParenList
+" syn region shParen matchgroup=shArithRegion start='\$\@!(\%(\ze[^(]\|$\)' end=')' contains=@shArithParenList

that probably does not belong here


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19818/review/4009320409@github.com>

dkearns

unread,
Mar 25, 2026, 4:56:39 PM (14 hours ago) Mar 25
to vim/vim, Push

@dkearns pushed 1 commit.

  • 2198dd7 runtime(algol68): Add new syntax file and filetype detection


View it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19818/before/4131534dec1d8386a6adc8f59844a5635920180b/after/2198dd754ba55db0e89b3f5bd41b6c55aade48f6@github.com>

dkearns

unread,
Mar 25, 2026, 5:03:35 PM (14 hours ago) Mar 25
to vim/vim, Push

@dkearns pushed 1 commit.

  • 1640d1c runtime(algol68): Add new syntax file and filetype detection


View it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19818/before/2198dd754ba55db0e89b3f5bd41b6c55aade48f6/after/1640d1c7d872ff7a68e91f7e7a15407c60790fd7@github.com>

dkearns

unread,
Mar 25, 2026, 5:40:18 PM (13 hours ago) Mar 25
to vim/vim, Push

@dkearns pushed 1 commit.

  • aed8698 Replace all groups in patterns with the non-capturing variant \%(...\)


View it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19818/before/1640d1c7d872ff7a68e91f7e7a15407c60790fd7/after/aed86984e9fd6fe163fc3a9345171bebeabb26aa@github.com>

dkearns

unread,
Mar 25, 2026, 6:02:35 PM (13 hours ago) Mar 25
to vim/vim, Subscribed
dkearns left a comment (vim/vim#19818)

@chrisbra, it's too early to be reviewing. As I mentioned in the mail thread it'll take a few days to finalise, I was just trying to put it in motion during the last minutes of the day.

Thanks. What is the issue with the many commented out lines in the syntax script?

These are in the original patch and appear to exclude the non-ASCII operators. I don't think there's any reason these can't eventually be supported. These commented-out lines are also apparent in version 0.2 from fifteen years ago.

There's also what looks like some experimentation with priorities of the operator patterns, tests would be useful to clean this up.

Can you please also update the MAINTAINERS file?

I doubt Janis, from comments in the mail thread, has a GitHub handle so I've just used mine for now.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19818/c4130119641@github.com>

Christian Brabandt

unread,
Mar 25, 2026, 6:08:35 PM (12 hours ago) Mar 25
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#19818)

@chrisbra, it's too early to be reviewing.

Ah okay, I'll hold off then, thanks for taking care


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19818/c4130148314@github.com>

dkearns

unread,
Mar 25, 2026, 6:12:40 PM (12 hours ago) Mar 25
to vim/vim, Push

@dkearns pushed 1 commit.

  • 7a7d84f Add a rudimentary ftplugin.


View it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19818/before/aed86984e9fd6fe163fc3a9345171bebeabb26aa/after/7a7d84f9acf44f8975b115ec65db520bf939e257@github.com>

dkearns

unread,
2:06 AM (5 hours ago) 2:06 AM
to vim/vim, Push

@dkearns pushed 1 commit.

  • 4fd060a Add a rudimentary ftplugin.


View it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19818/before/7a7d84f9acf44f8975b115ec65db520bf939e257/after/4fd060a4d24979f79e4c0ca581ae5b4aadf98d59@github.com>

Reply all
Reply to author
Forward
0 new messages