[vim/vim] runtime(skhd): Add skhd syntax file (PR #19235)

Kiyoon Kim

unread,

Jan 21, 2026, 8:36:29 PM (2 days ago) Jan 21

to vim/vim, Subscribed

Add syntax highlighting for skhd (simple hotkey daemon for macOS) configuration files. Includes filetype detection for skhdrc and .skhdrc files.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/19235

Commit Summary

84e44d3 runtime(skhd): Add skhd syntax file

File Changes

(10 files)

M .github/MAINTAINERS (1)
M runtime/filetype.vim (3)
A runtime/syntax/skhd.vim (137)
A runtime/syntax/testdir/dumps/skhdrc_00.dump (20)
A runtime/syntax/testdir/dumps/skhdrc_01.dump (20)
A runtime/syntax/testdir/dumps/skhdrc_02.dump (20)
A runtime/syntax/testdir/dumps/skhdrc_03.dump (20)
A runtime/syntax/testdir/dumps/skhdrc_04.dump (20)
A runtime/syntax/testdir/dumps/skhdrc_05.dump (20)
A runtime/syntax/testdir/input/skhdrc (102)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Kiyoon Kim

unread,

Jan 21, 2026, 8:45:40 PM (2 days ago) Jan 21

to vim/vim, Push

@kiyoon pushed 1 commit.

45e80fc runtime(skhd): Add skhd syntax file

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

Kiyoon Kim

unread,

Jan 21, 2026, 11:07:23 PM (2 days ago) Jan 21

to vim/vim, Subscribed

kiyoon left a comment (vim/vim#19235)

How do I fix the failing CI?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

dkearns

unread,

Jan 22, 2026, 7:41:51 AM (yesterday) Jan 22

to vim/vim, Subscribed

@dkearns requested changes on this pull request.

Thanks for the PR and extra browny points for the syntax test file.

Could you also add a simple ftplugin that defines, at least, comments and commentstring?

In Filelist:

> @@ -1192,5 +1192,6 @@ IGNORE = \
 		ci/hlgroups.ignore \
 		src/libvterm/CODE-MAP \
 		runtime/syntax/testdir/input/html_html \
+		runtime/syntax/testdir/input/skhdrc \

This line should be deleted. We don't want to ignore it and the input test files are included at https://github.com/vim/vim/blob/10b272c126e906b6bab3621b162ae7faea42472a/Filelist#L915

In runtime/filetype.vim:

> @@ -1055,6 +1055,9 @@ au BufNewFile,BufRead *.scm,*.ss,*.sld,*.stsg,*/supertux2/config,.lips_repl_hist
 " SiSU
 au BufNewFile,BufRead *.sst.meta,*.-sst.meta,*._sst.meta setf sisu
 
+" skhd(hotkey daemon) configuration file
+au BufNewFile,BufRead skhdrc,.skhdrc		setf skhd

This should now be configured in https://github.com/vim/vim/blob/master/runtime/autoload/dist/ft.vim

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Kiyoon Kim

unread,

Jan 22, 2026, 1:10:52 PM (23 hours ago) Jan 22

to vim/vim, Subscribed

@kiyoon commented on this pull request.

In Filelist:

> @@ -1192,5 +1192,6 @@ IGNORE = \
 		ci/hlgroups.ignore \
 		src/libvterm/CODE-MAP \
 		runtime/syntax/testdir/input/html_html \
+		runtime/syntax/testdir/input/skhdrc \

it's not included because it doesn't have an extension. That's why the CI failed earlier.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Kiyoon Kim

unread,

Jan 22, 2026, 1:16:18 PM (23 hours ago) Jan 22

to vim/vim, Push

@kiyoon pushed 1 commit.

2039a4e move to runtime/autoload/dist/ft.vim

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Kiyoon Kim

unread,

Jan 22, 2026, 1:18:28 PM (22 hours ago) Jan 22

to vim/vim, Subscribed

@kiyoon commented on this pull request.

In runtime/filetype.vim:

> @@ -1055,6 +1055,9 @@ au BufNewFile,BufRead *.scm,*.ss,*.sld,*.stsg,*/supertux2/config,.lips_repl_hist
 " SiSU
 au BufNewFile,BufRead *.sst.meta,*.-sst.meta,*._sst.meta setf sisu
 
+" skhd(hotkey daemon) configuration file
+au BufNewFile,BufRead skhdrc,.skhdrc		setf skhd

done

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Kiyoon Kim

unread,

Jan 22, 2026, 1:27:43 PM (22 hours ago) Jan 22

to vim/vim, Push

@kiyoon pushed 1 commit.

073cb22 runtime(skhd): Add skhd syntax file

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Kiyoon Kim

unread,

Jan 22, 2026, 7:56:44 PM (16 hours ago) Jan 22

to vim/vim, Subscribed

kiyoon left a comment (vim/vim#19235)

Could you also add a simple ftplugin that defines, at least, comments and commentstring?

Done!

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

dkearns

unread,

5:39 AM (6 hours ago) 5:39 AM

to vim/vim, Subscribed

@dkearns commented on this pull request.

In runtime/syntax/skhd.vim:

> +syn region skhdProcMapBlock
+      \ matchgroup=skhdProcMapDelim
+      \ start=/\v\[\s*$/
+      \ end=/^\s*\]\s*$/
+      \ keepend
+      \ transparent
+      \ contains=skhdProcMapApp,skhdProcMapWildcard,skhdProcMapUnbind,skhdOperator,skhdComment,skhdBash,skhdString
+
+" App name on the left side:  "Google Chrome" :
+syn match skhdProcMapApp /^\s*\zs"[^"]*"\ze\s*:\s*/ contained
+
+" Wildcard entry:  * :
+syn match skhdProcMapWildcard /^\s*\zs\*\ze\s*:\s*/ contained
+
+" Unbind operator on the right side:  "App" ~   or   * ~
+syn match skhdProcMapUnbind /\v^\s*(\"[^"]*\"|\*)\s*\zs~\ze\s*$/ contained

⬇️ Suggested change

-syn match skhdProcMapUnbind /\v^\s*(\"[^"]*\"|\*)\s*\zs~\ze\s*$/ contained
+syn match skhdProcMapUnbind /\v^\s*(\"[^"]*\"|\*)\s*\zs\~\ze\s*$/ contained
+``
+
+A bare `~` matches the previous substitute pattern.  This won't match and will generate E33 errors.
+
+See `:help /~` and `:help E33`.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

dkearns

unread,

5:42 AM (6 hours ago) 5:42 AM

to vim/vim, Subscribed

@dkearns commented on this pull request.

In Filelist:

> @@ -1192,5 +1192,6 @@ IGNORE = \
 		ci/hlgroups.ignore \
 		src/libvterm/CODE-MAP \
 		runtime/syntax/testdir/input/html_html \
+		runtime/syntax/testdir/input/skhdrc \

I couldn't find the test failure you're referring to but it certainly shouldn't be in the ignored list.

The input test file currently need to named something like skhd.skhd (with the filetype at the head of the filename) and as that won't be filetype detected by name it also needs a modeline like # vim:ft=skhd: at the bottom of the file.

You'll have to regenerate the dump files as they'll now have different names.

I think this might be the first syntax file that's detection is based on name and not extension. We can look at making this a bit simpler in the future.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Kiyoon Kim

unread,

8:29 AM (3 hours ago) 8:29 AM

to vim/vim, Push

@kiyoon pushed 1 commit.

5be5c55 runtime(skhd): Add skhd syntax file

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Kiyoon Kim

unread,

8:31 AM (3 hours ago) 8:31 AM

to vim/vim, Push

@kiyoon pushed 1 commit.

4df7d6c runtime(skhd): Add skhd syntax file

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Kiyoon Kim

unread,

8:32 AM (3 hours ago) 8:32 AM

to vim/vim, Subscribed

@kiyoon commented on this pull request.

In Filelist:

> @@ -1192,5 +1192,6 @@ IGNORE = \
 		ci/hlgroups.ignore \
 		src/libvterm/CODE-MAP \
 		runtime/syntax/testdir/input/html_html \
+		runtime/syntax/testdir/input/skhdrc \

done!

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Kiyoon Kim

unread,

8:33 AM (3 hours ago) 8:33 AM

to vim/vim, Subscribed

@kiyoon commented on this pull request.

In runtime/syntax/skhd.vim:

> +syn region skhdProcMapBlock
+      \ matchgroup=skhdProcMapDelim
+      \ start=/\v\[\s*$/
+      \ end=/^\s*\]\s*$/
+      \ keepend
+      \ transparent
+      \ contains=skhdProcMapApp,skhdProcMapWildcard,skhdProcMapUnbind,skhdOperator,skhdComment,skhdBash,skhdString
+
+" App name on the left side:  "Google Chrome" :
+syn match skhdProcMapApp /^\s*\zs"[^"]*"\ze\s*:\s*/ contained
+
+" Wildcard entry:  * :
+syn match skhdProcMapWildcard /^\s*\zs\*\ze\s*:\s*/ contained
+
+" Unbind operator on the right side:  "App" ~   or   * ~
+syn match skhdProcMapUnbind /\v^\s*(\"[^"]*\"|\*)\s*\zs~\ze\s*$/ contained

fixed! Thanks for catching it out

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward