[vim/vim] test_spell: personal spell files leak into later tests (PR #20766)

[coyaSONG]

Problem

Test_spelldump_prefixtree_overflow() resets 'runtimepath' to its default value during cleanup. That reintroduces the user's Vim directory, so later spell tests can load a personal .spl file and fail. With a personal en.utf-8.add.spl, the unmodified test suite reproduced the Test_spellinfo() failure reported in #20765.

Solution

Save the test runner's existing 'runtimepath' before adding Xrtp, then restore that exact value during cleanup instead of resetting the option to its user default.

Verification

• make -j4 passed.
• Before the change, HOME containing ~/.vim/spell/en.utf-8.add.spl reproduced the reported Test_spellinfo() failure.
• After the change, the same HOME passed all 46 relevant spell tests when excluding Test_compl_with_CTRL_X_s, a local screen-message assertion that fails identically with an empty HOME.
• The codestyle suite passed all 5 tests.
• git diff --check passed.

This contribution was prepared with OpenAI Codex assistance. I reviewed and validated the final change, and the commit includes an AI co-author trailer and my DCO sign-off.

Closes #20765

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20766

Commit Summary

• 6038c21 test_spell: personal spell files leak into later tests

File Changes

(1 file)

• M src/testdir/test_spell.vim (4)

Patch Links:

• https://github.com/vim/vim/pull/20766.patch
• https://github.com/vim/vim/pull/20766.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20766@github.com>