[vim/vim] docs: clarify term_start() I/O behavior for Unix pty and MS-Windows ConPTY (PR #19892)
h_east
Explain how stdin/stdout/stderr are connected in term_start():
- On Unix, they default to pty; only "err_cb" switches stderr to a pipe, which may cause output order differences due to buffering.
- On MS-Windows with ConPTY, they are always pipes and stdout/stderr share the same pipe, so "err_cb" cannot separate them.
Related: #16354
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19892
Commit Summary
- bedd8a7 docs: clarify term_start() I/O behavior for Unix pty and MS-Windows ConPTY
File Changes
(1 file)
- M runtime/doc/terminal.txt (20)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
h_east
h-east left a comment (vim/vim#19892)@mattn Mind giving this a quick review?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
mattn
@mattn commented on this pull request.
LGTM.
If you think it's worth mentioning the technical reason, the CreatePseudoConsole() API itself only takes one input and one output handle (no separate stderr), which is why they can't be separated:
https://learn.microsoft.com/en-us/windows/console/createpseudoconsole
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
mattn
mattn left a comment (vim/vim#19892)As you may know, job_start() does not use CreatePseudoConsole(), so err_cb correctly separates stderr there.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
h_east
@h-east pushed 1 commit.
- eb3dd9e Added information received from review comments
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
h_east
h-east left a comment (vim/vim#19892)@mattn Thanks for the reviewing. I added information based on your comments.
As you may know, job_start() does not use CreatePseudoConsole(), so err_cb correctly separates stderr there.
Yeah, The text added in this pull request is within :h term_start(), so it's fine.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19892)thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19892)included as of 0646047
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.