[vim/vim] Distinguish between Forth and Fortran filetypes for *.f files (PR #12251)
Doug Kearns
Also adds *.4th as a Forth filetype
@jkotlinski, could you please run your eyes over this?
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/12251
Commit Summary
- 93ad6bd Distinguish between Forth and Fortran filetypes for *.f files
File Changes
(5 files)
- M runtime/autoload/dist/ft.vim (47)
- M runtime/doc/filetype.txt (1)
- M runtime/doc/syntax.txt (7)
- M runtime/filetype.vim (9)
- M src/testdir/test_filetype.vim (52)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Codecov Report
Merging #12251 (93ad6bd) into master (b6ebe5a) will increase coverage by
0.38%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #12251 +/- ## ========================================== + Coverage 81.94% 82.32% +0.38% ========================================== Files 164 154 -10 Lines 194114 183698 -10416 Branches 43832 41405 -2427 ========================================== - Hits 159060 151225 -7835 + Misses 22213 19918 -2295 + Partials 12841 12555 -286
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | 82.66% <ø> (+0.03%) |
⬆️ |
| huge-gcc-none | ? |
|
| huge-gcc-testgui | 51.96% <ø> (+<0.01%) |
⬆️ |
| huge-gcc-unittests | 0.29% <ø> (-0.01%) |
⬇️ |
| linux | 82.32% <ø> (-0.07%) |
⬇️ |
| mingw-x64-HUGE | ? |
|
| mingw-x86-HUGE | ? |
|
| windows | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
see 133 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Johan Kotlinski
Hey, sorry, I missed the notification. I will have a look.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Johan Kotlinski
@jkotlinski commented on this pull request.
In runtime/autoload/dist/ft.vim:
> + return false
+enddef
+
+# Distinguish between Forth and Fortran
+export def FTf()
+ if exists("g:filetype_f")
+ exe "setf " .. g:filetype_f
+ return
+ endif
+
+ var first_line = getline(nextnonblank(1))
+
+ # SwiftForth block comment, line is usually filled with '-' or '='
+ var header_comment = first_line =~ '^{\%(\s\|$\)'
+ # SwiftForth OPTIONAL, sometimes appears before the header comment
+ var optional_include = first_line =~ '^OPTIONAL\s'
Could the SwiftForth checks give false positives for F#? If not, I think they would be better moved to the IsForth() function.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Doug Kearns
I don't believe so. I'll push the extra tests into IsForth().
Thanks.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Doug Kearns
@dkearns pushed 1 commit.
- 667483a Distinguish between Forth and Fortran filetypes for *.f files
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Johan Kotlinski
@jkotlinski commented on this pull request.
>
" Reva Forth
au BufNewFile,BufRead *.frt setf reva
" Fortran
if has("fname_case")
- au BufNewFile,BufRead *.F,*.FOR,*.FPP,*.FTN,*.F77,*.F90,*.F95,*.F03,*.F08 setf fortran
+ au BufNewFile,BufRead *.F,*.FOR,*.FPP,*.FTN,*.F77,*.F90,*.F95,*.F03,*.F08 setf fortran
Is it intentional that *.F is still mapped to Fortran only?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Doug Kearns
@dkearns commented on this pull request.
>
" Reva Forth
au BufNewFile,BufRead *.frt setf reva
" Fortran
if has("fname_case")
- au BufNewFile,BufRead *.F,*.FOR,*.FPP,*.FTN,*.F77,*.F90,*.F95,*.F03,*.F08 setf fortran
+ au BufNewFile,BufRead *.F,*.FOR,*.FPP,*.FTN,*.F77,*.F90,*.F95,*.F03,*.F08 setf fortran
It is on the grounds that:
- Fortran has some conventions for uppercase extensions that makes them meaningful.
- We don't support uppercase for any other Forth extensions or other filetypes in general.
- SwiftForth (a notable user of
*.f) doesn't implicitly recognise*.Fas it does*f.
Is there some history of intentionally capitalised extensions?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Johan Kotlinski
@jkotlinski commented on this pull request.
>
" Reva Forth
au BufNewFile,BufRead *.frt setf reva
" Fortran
if has("fname_case")
- au BufNewFile,BufRead *.F,*.FOR,*.FPP,*.FTN,*.F77,*.F90,*.F95,*.F03,*.F08 setf fortran
+ au BufNewFile,BufRead *.F,*.FOR,*.FPP,*.FTN,*.F77,*.F90,*.F95,*.F03,*.F08 setf fortran
Not that I am aware of. I was simply unaware of Fortran conventions.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
Can you please update and rebase this PR to the latest?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
@yegappan I vaguely recall I was going to tag a test file refactoring (Test_*_file helper) onto this PR but let's leave that for another time.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.