[vim/vim] ":silent make" leaves the window blank until CTRL-L (PR #21329)
h_east
Problem: After ":silent make" or ":silent grep" the window stays blank
until the screen is redrawn by hand.
Solution: Ask wait_return() for the redraw even when messages are
silent. It skips the hit-enter prompt for ":silent" on its
own, so the argument "msg_silent == 0" only took away the
set_must_redraw(UPD_CLEAR) that draws the window again.
related: #529
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/21329
Commit Summary
- 7ad7df9 ":silent make" leaves the window blank until CTRL-L
File Changes
(3 files)
- M src/ex_cmds.c (4)
- A src/testdir/dumps/Test_quickfix_silent_make_1.dump (8)
- M src/testdir/test_quickfix.vim (18)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#21329)Hm, I am not sure, this is a behavioral change. It is true that currently this: :sil !seq 1 10 when Vim switches screens (e.g. t_ti and t_te are not empty) or in a GUI, does not make much sense, e.g. it redraws after the command finishes and you do not see the command output. But on the other hand try this in terminal vim: vim --clean -c 'set t_ti= t_te=' and once Vim is started run :sil !seq 1 10. You'll see the command output without a hit-enter prompt. This is no longer possible with this patch.
So I think we should do this either when GUI is running or when switching screens is enabled. Or only when we are running :make (or :grep)?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
h_east
h-east left a comment (vim/vim#21329)Fixed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.