[vim/vim] patch 9.2.XXXX: GTK3: Dialog buttons have no keyboard shortcuts. (PR #21411)

8 views

Skip to first unread message

Tom M

unread,

Sep 30, 2026, 2:25:27 PM (21 hours ago) Sep 30

to vim/vim, Subscribed

Problem: GTK3: Dialog buttons have no keyboard shortcuts.
Solution: Delete code in dialog_add_buttons() that removes shortcuts specified by callers.

What does this change do?

This allows to choose "OK" , "Yes", "No" or "Cancel" buttons using the keyboard (via keyboard shortcuts) in GTK3 dialog popups. It was possible in GTK2 but the current code for GTK3 does not allow this at the moment. The relevant GTK3 code is an adaptation of a GTK2 code but its effect is that it removes shortcuts that are requested by caller functions.

Commit message

Problem:  GTK3: Dialog buttons have no keyboard shortcuts.
Solution: Delete code in dialog_add_buttons() that removes shortcuts
          specified by callers.

AI assistance

AI involvement is disclosed in the commit message, or no AI was used

Checklist

The commit message follows the Problem/Solution form above
Signed-off-by: trailer is present (git commit -s), recommended but not required
Tests were added, existing tests cover the change, or the change cannot be tested (say why) -- Can't find an easy way how to test this.
Documentation under runtime/doc/ was updated, or no update is needed

Anything reviewers should know

Screenshots

Old dialog popup buttons without keyboard shortcuts.
Image: YesNoCancel_old (view on web)
New dialog popup buttons with keyboard shortcuts.
Image: YesNoCancel_new (view on web)

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/21411

Commit Summary

2028260 patch 9.2.XXXX: GTK3: Dialog buttons have no keyboard shortcuts.

File Changes

(1 file)

M src/gui_gtk.c (11)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.

Tom M

unread,

Sep 30, 2026, 3:39:55 PM (19 hours ago) Sep 30

to vim/vim, Subscribed

tom-m left a comment (vim/vim#21411)

@nuko8, the deleted lines are yours. To be honest I am not 100% sure I understand what's their purpose other than removing keyboard shortcuts. Was the removal intentional? Are they needed also for "normalization" of names (e.g. "OK" instead of "Ok")?