[vim/vim] runtime(python): highlight 'self' and 'cls' (PR #17968)
Jon Parise
These are special names by convention, and giving them distinct highlighting is a nice visual cue (using Identifier by default).
This group is named 'pythonClassVar' to match the name used by python-syntax. Some third-party color schemes are aware of this name and customized their colors accordingly.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/17968
Commit Summary
- 22a191e runtime(python): highlight 'self' and 'cls'
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Jon Parise
jparise left a comment (vim/vim#17968)@zvezdan as discussed, I chose the simplest approach that still allows users to re-link or clear this new highlight group.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Zvezdan Petkovic
@zvezdan commented on this pull request.
Looks good.
I would just make a location change in the file and add a small comment.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Zvezdan Petkovic
@zvezdan commented on this pull request.
Looks good.
I would just make a location change and add a comment.
> @@ -105,6 +105,7 @@ syn keyword pythonOperator and in is not or syn keyword pythonException except finally raise try syn keyword pythonInclude from import syn keyword pythonAsync async await +syn keyword pythonClassVar self cls
I wouldn't put them in this group of real keywords because they wouldn't be in the output of the command above in the comment (line 95).
Perhaps moving them below soft keywords with an appropriate comment that they are de facto convention, rather than the real keywords. After all, we could call them Bob and Fred and the result would be the same. We don't do that because it's not a convention and wouldn't be nice to the code maintainers. 🙂
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Jon Parise
@jparise pushed 1 commit.
- b9e5404 runtime(python): give pythonClassVar its own section
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Jon Parise
@jparise commented on this pull request.
> @@ -105,6 +105,7 @@ syn keyword pythonOperator and in is not or syn keyword pythonException except finally raise try syn keyword pythonInclude from import syn keyword pythonAsync async await +syn keyword pythonClassVar self cls
Good idea. I relocated them with a comment in the latest commit (b9e5404).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Zvezdan Petkovic
@zvezdan approved this pull request.
Looks good.
Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#17968)thanks
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.